overlay.d/05core: add ifname= karg udev rule propagation #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
May 5, 2023
tests/kola/networking/ifname-karg/everyboot-systemd-link-file/config.bu
Outdated
Show resolved
Hide resolved
| # The expected IP is the first one in the range given out by QEMU | ||
| # user mode networking: https://www.qemu.org/docs/master/system/devices/net.html#using-the-user-mode-network-stack | ||
| expected_ip="10.0.2.15" | ||
| # Verify the given nic name has the expected IP. F |
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-ignition/coreos-teardown-initramfs.sh
Outdated
Show resolved
Hide resolved
The link was to testiso code, which isn't the code being excercised here. Let's just update the comment to say it's the default one QEMU assigns.
This adds to coreos-teardown-initramfs.{service,sh} the ability to
propagate udev rules that were generated by ifname-genrules.sh [1]
to the real root of the machine to allow for an ephemeral ifname=
karg on the first boot to have persistent configuration effect (similar
to our other networking kernel arguments).
This also adds tests for both the firstboot and everyboot case for
the ifname= karg.
Fixes coreos/fedora-coreos-tracker#553
[1] https://github.com/dracutdevs/dracut/blob/5c3d0a96473ac339fa2d1b25213b8f301c1cfd0d/modules.d/40network/ifname-genrules.sh
dustymabe
force-pushed
the
dusty-persist-ifname-karg
branch
from
002e08f
to
84bc230
Compare
|
Addressed comments in the latest upload. |
jlebon
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to coreos-teardown-initramfs.{service,sh} the ability to propagate udev rules that were generated by ifname-genrules.sh [1] to the real root of the machine to allow for an ephemeral ifname= karg on the first boot to have persistent configuration effect (similar to our other networking kernel arguments).
This also adds tests for both the firstboot and everyboot case for the ifname= karg.
Fixes coreos/fedora-coreos-tracker#553
[1] https://github.com/dracutdevs/dracut/blob/5c3d0a96473ac339fa2d1b25213b8f301c1cfd0d/modules.d/40network/ifname-genrules.sh