-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectively enable ostree autopruning #2435
Conversation
manifests/fedora-coreos.yaml
Outdated
# Need OSTree autopruning on aarch64 until we stop removing the qcom dtb files | ||
# as was done in https://github.com/coreos/fedora-coreos-tracker/issues/1464 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comment looks incorrect since we are not removing the blobs in this path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right. I rewrote the comment. Hopefully it is more accurate now.
d575e9f
to
e393086
Compare
Once coreos/fedora-coreos-config#2435 merges we should be unblocked for releasing ppc64le. We'll do a soft rollout with just `testing`/`next` for now.
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
The ppc64le arch has been blocked [1] from being fully released because of size limitations in /boot not being able to hold 3 copies of kernel+initramfs because the kernel on ppc64le isn't compressed [2]. Now that OSTree Autopruning [3] has landed let's enable it on ppc64le to unblock ourselves. [1] coreos/fedora-coreos-tracker#987 (comment) [2] coreos/fedora-coreos-tracker#1247 (comment) [3] coreos/fedora-coreos-tracker#1495
Now that we have autopruning ability we can re-add the qcom dtbs on aarch64 that were dropped in coreos/fedora-coreos-tracker#1464 Fixes coreos/fedora-coreos-tracker#1467
It has a fix for an autopruning corner case. ostreedev/ostree#2866
e393086
to
017917b
Compare
ok I pushed up a commit to fast track a new ostree RPM with a autoprune corner case fixed. This should be ready to merge now (if it passes CI). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the latest commit and went over the previous ones briefly. LGTM.
This adds autopruning for ppc64le so we can start to officially release it.
It also adds back in the qualcomm dtbs and autopruning for aarch64 on F39+, which allows us to passively pick up the change when the
next-devel
branch is re-enabled at F39 beta time. If we re-enable thenext-devel
branch earlier then we can change this to pick it up quicker too.Finally, there is a commit in there to drop some code that's no longer necessary.