selectively enable ostree autopruning #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
commented
May 26, 2023
jlebon
reviewed
May 26, 2023
manifests/fedora-coreos.yaml
Outdated
Comment on lines
35
to
36
| # Need OSTree autopruning on aarch64 until we stop removing the qcom dtb files | ||
| # as was done in https://github.com/coreos/fedora-coreos-tracker/issues/1464 |
There was a problem hiding this comment.
That comment looks incorrect since we are not removing the blobs in this path.
There was a problem hiding this comment.
I think you are right. I rewrote the comment. Hopefully it is more accurate now.
dustymabe
force-pushed
the
dusty-os-autoprune
branch
from
d575e9f
to
e393086
Compare
jlebon
previously approved these changes
May 26, 2023
dustymabe
added a commit
to dustymabe/fedora-coreos-pipeline
that referenced
this pull request
May 26, 2023
Once coreos/fedora-coreos-config#2435 merges we should be unblocked for releasing ppc64le. We'll do a soft rollout with just `testing`/`next` for now.
Mostly a revert of e49baba. This was fixed in dracut some time ago [1] and this is now dead code since we are on F38. [1] dracutdevs/dracut#1777
The ppc64le arch has been blocked [1] from being fully released because of size limitations in /boot not being able to hold 3 copies of kernel+initramfs because the kernel on ppc64le isn't compressed [2]. Now that OSTree Autopruning [3] has landed let's enable it on ppc64le to unblock ourselves. [1] coreos/fedora-coreos-tracker#987 (comment) [2] coreos/fedora-coreos-tracker#1247 (comment) [3] coreos/fedora-coreos-tracker#1495
Now that we have autopruning ability we can re-add the qcom dtbs on aarch64 that were dropped in coreos/fedora-coreos-tracker#1464 Fixes coreos/fedora-coreos-tracker#1467
It has a fix for an autopruning corner case. ostreedev/ostree#2866
dustymabe
force-pushed
the
dusty-os-autoprune
branch
from
e393086
to
017917b
Compare
|
ok I pushed up a commit to fast track a new ostree RPM with a autoprune corner case fixed. This should be ready to merge now (if it passes CI). |
cgwalters
approved these changes
May 31, 2023
gursewak1997
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds autopruning for ppc64le so we can start to officially release it.
It also adds back in the qualcomm dtbs and autopruning for aarch64 on F39+, which allows us to passively pick up the change when the
next-develbranch is re-enabled at F39 beta time. If we re-enable thenext-develbranch earlier then we can change this to pick it up quicker too.Finally, there is a commit in there to drop some code that's no longer necessary.