Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google-compute-engine-guest-configs-udev package #2450

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

ravanelli
Copy link
Member

@ravanelli
Copy link
Member Author

/hold

The google-compute-engine-guest-configs-udev package still not part of the Fedora Repo yet.
I think we need to wait it to be promoted/ the repo be updated to get it.
The latest version we have is from 2023-05-168 in the updates repo:
https://dl.fedoraproject.org/pub/fedora/linux/updates/38/Everything/x86_64/Packages/g/

@ravanelli ravanelli added the hold label Jun 2, 2023
@dustymabe
Copy link
Member

It's still in bodhi testing. https://bodhi.fedoraproject.org/updates/FEDORA-2023-84a4fea7ce

Just add an override for it.

@cgwalters
Copy link
Member

That update had karma set to 3, which is just unrealistic. I lowered it to 1. If someone's tested this out, please just give it a single karma.

@dustymabe
Copy link
Member

IIUC this PR needs to also delete the 30gcp-udev-rules overlay.

…comments

This makes it a little more clear what comment is related to what
packages in the list.
@dustymabe dustymabe force-pushed the guest_config branch 2 times, most recently from 68c7d55 to 4c2db49 Compare June 5, 2023 22:49
@dustymabe
Copy link
Member

This should be ready for review now. cc @HuijingHei

@dustymabe dustymabe removed the hold label Jun 5, 2023
…-rules overlay

The udev rules and dracut module are now offered by the package.
See: coreos/fedora-coreos-tracker#1494

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Co-authored-by: Dusty Mabe <dusty@dustymabe.com>
@dustymabe dustymabe enabled auto-merge (rebase) June 6, 2023 02:16
@HuijingHei
Copy link
Member

HuijingHei commented Jun 6, 2023

Try to do some testing, but stuck in cosa fetch.

After run cosa fetch, get error about Couldn't find locked package 'google-compute-engine-guest-configs-udev-20230526.00-3.fc38.noarch' , but CI works well. Any suggestions?

rpm-ostree version: 2023.4
No previous commit for fedora/x86_64/coreos/testing-devel
Enabled rpm-md repositories: fedora-coreos-pool fedora fedora-updates
Updating metadata for 'fedora-coreos-pool'... done
Updating metadata for 'fedora'... done
Updating metadata for 'fedora-updates'... done
Importing rpm-md... done
rpm-md repo 'fedora-coreos-pool'; generated: 2023-06-05T18:37:51Z solvables: 17882
rpm-md repo 'fedora'; generated: 2023-04-13T20:37:10Z solvables: 69222
rpm-md repo 'fedora-updates'; generated: 2023-06-06T01:37:27Z solvables: 14722
warning: Couldn't find locked package 'google-compute-engine-guest-configs-udev-20230526.00-3.fc38.noarch'
  Packages matching NEVRA: 0; Mismatched checksums: 0
  Packages matching name and arch (1):
  google-compute-engine-guest-configs-udev-20230515.00-1.fc38.noarch (fedora-updates)
error: Packages not found: google-compute-engine-guest-configs-udev
error: failed to execute cmd-fetch: exit status 1

@travier
Copy link
Member

travier commented Jun 6, 2023

Looks like https://bodhi.fedoraproject.org/updates/FEDORA-2023-84a4fea7ce was obsoleted by https://bodhi.fedoraproject.org/updates/FEDORA-2023-67a6c1b831 which is still in testing. You can add a manifest override to get it now.

@travier
Copy link
Member

travier commented Jun 6, 2023

Looks like Dusty added it, not just why you're not getting the override

# Include the qemu-user-static-x86 package on non-x86_64 FCOS images to allow
# access to the large inventory of containers only built for x86_64.
# https://github.com/coreos/fedora-coreos-tracker/issues/1237
# - google-compute-engine-guest-configs-udev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be up for debate on whether we install this just for specific architectures or for only ones where it is needed.

@HuijingHei
Copy link
Member

Build fedora coreos container image locally, upload to quay.io, start confidential vm on GCP and rebase, check the result is expected.

[hhei@hhei-fcos ~]$ rpm -q google-compute-engine-guest-configs-udev
google-compute-engine-guest-configs-udev-20230526.00-3.fc38.noarch

[hhei@hhei-fcos ~]$ sudo /usr/lib/udev/google_nvme_id -d /dev/nvme0n1
ID_SERIAL_SHORT=local-nvme-ssd-0
ID_SERIAL=Google_EphemeralDisk_local-nvme-ssd-0
[hhei@hhei-fcos ~]$ sudo /usr/lib/udev/google_nvme_id -d /dev/nvme1n1
/usr/lib/udev/google_nvme_id: line 61: warning: command substitution: ignored null byte in input
ID_SERIAL_SHORT=persistent-disk-0
ID_SERIAL=Google_PersistentDisk_persistent-disk-0

[hhei@hhei-fcos ~]$ ls -l /dev/disk/by-id/google-local-nvme-ssd-0
lrwxrwxrwx. 1 root root 13 Jun  6 13:33 /dev/disk/by-id/google-local-nvme-ssd-0 -> ../../nvme0n1
[hhei@hhei-fcos ~]$ ls -l /dev/disk/by-id/google-persistent-disk-0
lrwxrwxrwx. 1 root root 13 Jun  6 13:33 /dev/disk/by-id/google-persistent-disk-0 -> ../../nvme1n1

@HuijingHei
Copy link
Member

/LGTM
/approve

@dustymabe dustymabe merged commit 805c66c into coreos:testing-devel Jun 6, 2023
dustymabe added a commit to dustymabe/os that referenced this pull request Jun 8, 2023
These files were dropped from the FCOS overlay in [1] because
they are now being delivered via the google-compute-engine-guest-configs-udev
subpackage. Until this package exists in RHEL we'll add an overlay
to RHCOS with the rules (they have now been updated to match latest
upstream).

[1] coreos/fedora-coreos-config#2450
dustymabe added a commit to dustymabe/os that referenced this pull request Jun 8, 2023
These files were dropped from the FCOS overlay in [1] because
they are now being delivered via the google-compute-engine-guest-configs-udev
subpackage. Until this package exists in RHEL we'll add an overlay
to RHCOS with the rules (they have now been updated to match latest
upstream).

[1] coreos/fedora-coreos-config#2450
dustymabe added a commit to dustymabe/os that referenced this pull request Jun 9, 2023
These files were dropped from the FCOS overlay in [1] because
they are now being delivered via the google-compute-engine-guest-configs-udev
subpackage. Until this package exists in RHEL we'll add an overlay
to RHCOS with the rules (they have now been updated to match latest
upstream).

[1] coreos/fedora-coreos-config#2450

(cherry picked from commit 2513047)
@ravanelli ravanelli deleted the guest_config branch January 2, 2024 15:42
@ravanelli ravanelli restored the guest_config branch January 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants