-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google-compute-engine-guest-configs-udev package #2450
Conversation
/hold The |
It's still in bodhi testing. https://bodhi.fedoraproject.org/updates/FEDORA-2023-84a4fea7ce Just add an override for it. |
That update had karma set to 3, which is just unrealistic. I lowered it to 1. If someone's tested this out, please just give it a single karma. |
IIUC this PR needs to also delete the |
…comments This makes it a little more clear what comment is related to what packages in the list.
68c7d55
to
4c2db49
Compare
This should be ready for review now. cc @HuijingHei |
…-rules overlay The udev rules and dracut module are now offered by the package. See: coreos/fedora-coreos-tracker#1494 Signed-off-by: Renata Ravanelli <rravanel@redhat.com> Co-authored-by: Dusty Mabe <dusty@dustymabe.com>
Try to do some testing, but stuck in After run
|
Looks like https://bodhi.fedoraproject.org/updates/FEDORA-2023-84a4fea7ce was obsoleted by https://bodhi.fedoraproject.org/updates/FEDORA-2023-67a6c1b831 which is still in testing. You can add a manifest override to get it now. |
Looks like Dusty added it, not just why you're not getting the override |
# Include the qemu-user-static-x86 package on non-x86_64 FCOS images to allow | ||
# access to the large inventory of containers only built for x86_64. | ||
# https://github.com/coreos/fedora-coreos-tracker/issues/1237 | ||
# - google-compute-engine-guest-configs-udev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be up for debate on whether we install this just for specific architectures or for only ones where it is needed.
Build fedora coreos container image locally, upload to quay.io, start confidential vm on GCP and rebase, check the result is expected.
|
/LGTM |
These files were dropped from the FCOS overlay in [1] because they are now being delivered via the google-compute-engine-guest-configs-udev subpackage. Until this package exists in RHEL we'll add an overlay to RHCOS with the rules (they have now been updated to match latest upstream). [1] coreos/fedora-coreos-config#2450
These files were dropped from the FCOS overlay in [1] because they are now being delivered via the google-compute-engine-guest-configs-udev subpackage. Until this package exists in RHEL we'll add an overlay to RHCOS with the rules (they have now been updated to match latest upstream). [1] coreos/fedora-coreos-config#2450
These files were dropped from the FCOS overlay in [1] because they are now being delivered via the google-compute-engine-guest-configs-udev subpackage. Until this package exists in RHEL we'll add an overlay to RHCOS with the rules (they have now been updated to match latest upstream). [1] coreos/fedora-coreos-config#2450 (cherry picked from commit 2513047)
See: coreos/fedora-coreos-tracker#1494