tests: check that we should not find /dev/disk/by-id/google* device links on non GCP
#2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
force-pushed
the
check-google-dev-links
branch
from
1cb7e32 to
0aa3db9
Compare
|
I feel like maybe we should create a new test for this since it feels weird to just add it into another (seemingly unrelated) test. IIUC this doesn't require a specific disk setup so we could make it a non-exclusive test (that way we won't end up spawning an extra VM but just re-use the non-exclusive-tests VM. |
HuijingHei
force-pushed
the
check-google-dev-links
branch
2 times, most recently
from
83b68ad to
8c0e37a
Compare
SGTM. Thanks @dustymabe and @travier for the reivew. |
dustymabe
reviewed
Jun 27, 2023
|
maybe name the test |
HuijingHei
force-pushed
the
check-google-dev-links
branch
from
8c0e37a to
66bc87b
Compare
travier
reviewed
Jun 27, 2023
HuijingHei
force-pushed
the
check-google-dev-links
branch
from
66bc87b to
20de5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/OCPBUGS-13754
coreos/fedora-coreos-tracker#1475 (comment)