Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Add fwupd for all arches #2569

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

ravanelli
Copy link
Member

@ravanelli
Copy link
Member Author

The fwupd package was removed before in 4cae1d0.

Checking it for RHOS 4.14. I can't see the same errors:

[root@cosa-devsh core]# journalctl -u systemd-modules-load.service
Aug 28 18:08:58 localhost systemd-modules-load[347]: Inserted module 'fuse'
Aug 28 18:08:58 localhost systemd-modules-load[347]: Inserted module 'pkey'
Aug 28 18:08:58 localhost systemd[1]: Finished Load Kernel Modules.
Aug 28 18:09:04 localhost systemd[1]: systemd-modules-load.service: Deactivated successfully.
Aug 28 18:09:04 localhost systemd[1]: Stopped Load Kernel Modules.

cc: @jschintag

@dustymabe
Copy link
Member

I broke the whitespace fixes out into #2570

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!

@jschintag
Copy link
Contributor

I think i remember that s390x was excluded because there is no fwupd package for it.
Is there now one?
I have to admit i am unsure about s390x firmware, but i do not think that is updateable through the OS, but rather only from the Hardware Management Console or maybe even with physical access to the machine...

 - Add fwupd package for all architecture, eliminating the exclusion for 's390x';
 - Now that we enabled/start 'fwupd' by default in coreos#2562. We should have
   this package to all arhces.

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
@ravanelli
Copy link
Member Author

I think i remember that s390x was excluded because there is no fwupd package for it. Is there now one? I have to admit i am unsure about s390x firmware, but i do not think that is updateable through the OS, but rather only from the Hardware Management Console or maybe even with physical access to the machine...

Yes, there is one now. Let's say how it goes now, and if we find some issue again we should open an issue against fwupd to get that address this time.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier
Copy link
Member

travier commented Aug 29, 2023

Note that fwupd is not only used to update the system firmwares but also the firmwares of devices that are plugged into a system. Not sure how much use that would be on s390x however.

@ravanelli ravanelli merged commit d4da764 into coreos:testing-devel Aug 30, 2023
3 checks passed
@ravanelli ravanelli deleted the fwupd branch January 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants