-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: Add fwupd for all arches #2569
Conversation
ravanelli
commented
Aug 28, 2023
- Add fwupd package for all architecture, eliminating the exclusion for 's390x';
- Now that we enabled/start 'fwupd' by default in Enable fwupd refresh timer on Fedora 39 #2562. We should have this package to all arhces.
The Checking it for RHOS 4.14. I can't see the same errors:
cc: @jschintag |
I broke the whitespace fixes out into #2570 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me!
I think i remember that s390x was excluded because there is no fwupd package for it. |
- Add fwupd package for all architecture, eliminating the exclusion for 's390x'; - Now that we enabled/start 'fwupd' by default in coreos#2562. We should have this package to all arhces. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Yes, there is one now. Let's say how it goes now, and if we find some issue again we should open an issue against fwupd to get that address this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that fwupd is not only used to update the system firmwares but also the firmwares of devices that are plugged into a system. Not sure how much use that would be on s390x however. |