manifests: Move kernel into separate manifest #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
inherit-sagano-prep
branch
from
335ccb1
to
a4dc858
Compare
cgwalters
changed the title
cgwalters
force-pushed
the
inherit-sagano-prep
branch
6 times, most recently
from
01a73b4
to
fece2dd
Compare
|
Hmm, odd that this is required. The What was the depsolve error that you got? |
|
The problem is easy to replicate with this patch to the sagano configs: (Clearly we should error out in the depsolve phase, not finalization here if multiple things provide kernels) |
|
There are of course multiple other ways I can think of to address this. The first would be something like Under our inheritance rules this would allow something else to later do: and override instead of union. Even then though, it seems like just a Good Idea to me to separate the userspace configs from the kernel as is being done here. |
cgwalters
added
the
area/container-native
jlebon
previously approved these changes
Sep 21, 2023
This is prep for rebasing on [sagano](https://gitlab.com/cgwalters-playground/sagano) where I hit on the issue that to build images with `kernel-rt`, we need to clearly separate the `kernel` package from userspace stuff (`systemd`, `rpm-ostree`) etc. Note that we'll need to make the same change in RHCOS - until we rebase both on sagano.
cgwalters
force-pushed
the
inherit-sagano-prep
branch
from
fece2dd
to
1321289
Compare
cgwalters
changed the title
|
OK, addressed comments and queued for merge. |
jlebon
added a commit
to coreosbot-releng/os
that referenced
this pull request
Nov 9, 2023
This was split out in a separate manifest in coreos/fedora-coreos-config#2609 We'll probably rejig this soon once we inherit from the bootable container work, but for now this restore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep for rebasing on sagano
where I hit on the issue that to build images with
kernel-rt,we need to clearly separate the
kernelpackage from userspacestuff (
systemd,rpm-ostree) etc.Note that we'll need to make the same change in RHCOS - until
we rebase both on sagano.