upgrade/extended: Get latest release from update server #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Sep 21, 2023
tests/kola/upgrade/extended/test.sh
Outdated
| curl -L "https://updates.coreos.fedoraproject.org/v1/graph?basearch=$(arch)&stream=${stream}" > /srv/releases.json | ||
| last_release=$(jq -r .nodes[-1].version /srv/releases.json) | ||
| last_release_index=$(jq -r '.nodes[-1].metadata."org.fedoraproject.coreos.releases.age_index"' /srv/releases.json) | ||
| latest_edge=$(jq -r .edges[0][1] /srv/releases.json) |
There was a problem hiding this comment.
I wasn't sure if the order of the edges was guaranteed, but we can probbably go with this for now until it proves to be a bad assumption.
There was a problem hiding this comment.
Saw other streams json files, assumption's been true so far. Will keep an eye though.
dustymabe
reviewed
Sep 21, 2023
tests/kola/upgrade/extended/test.sh
Outdated
| @@ -75,10 +75,19 @@ get_booted_deployment_json() { | |||
| version=$(get_booted_deployment_json | jq -r '.version') | |||
| stream=$(get_booted_deployment_json | jq -r '.["base-commit-meta"]["fedora-coreos.stream"]') | |||
|
|
|||
| # Pick up the last release for the current stream | |||
| # Pick up the last release for the current stream from the update server | |||
| test -f /srv/releases.json || \ | |||
There was a problem hiding this comment.
I think make let's not call this releases.json any longer since we're pulling the information from somewhere else. Maybe updateinfo.json or similar?
This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
gursewak1997
force-pushed
the
fix-upgradeext
branch
from
c4f9f49
to
d040188
Compare
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails when it is run during the time period between the stream build and the release. Updated the test to get the
last_releasefrom update server and check if there's an edge pointing to it. If there is no pointing edge to ourlast_release, we would just pick up the second last release from the json.