-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rawhide] Switch to deploying via container image #2711
Conversation
I thought we tried to make this change sometime recently and we couldn't for some reason. If it works then LGTM! |
CI failure is maybe related to coreos/zincati#859 ? |
It needs coreos/zincati#876 |
4b1b07a
to
5ab64a6
Compare
The most recent CI run has
|
5ab64a6
to
a86e624
Compare
OK split out the test fix into #2729 |
a86e624
to
4b4b043
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still LGTM, but the GH web UI is complaining about conflicts that will prevent merge.
Because rawhide is a mechanical stream, this won't break anything for production streams. It will help shake out anything that might be broken by this.
4b4b043
to
fa0b41c
Compare
ok I think I fixed the merge conflict and rebased on top of latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too.
Thanks! Let's keep an eye out for fallout. |
🔍 👀 |
Because rawhide is a mechanical stream, this won't break anything for production streams. It will help shake out anything that might be broken by this.