Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rawhide] Switch to deploying via container image #2711

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[rawhide] Switch to deploying via container image #2711

merged 1 commit into from
Nov 14, 2023

Conversation

cgwalters
Copy link
Member

Because rawhide is a mechanical stream, this won't break anything for production streams. It will help shake out anything that might be broken by this.

@dustymabe
Copy link
Member

I thought we tried to make this change sometime recently and we couldn't for some reason.

If it works then LGTM!

@dustymabe
Copy link
Member

CI failure is maybe related to coreos/zincati#859 ?

@cgwalters
Copy link
Member Author

It needs coreos/zincati#876

@cgwalters
Copy link
Member Author

It needs coreos/zincati#876

Built in https://koji.fedoraproject.org/koji/buildinfo?buildID=2316475

@dustymabe
Copy link
Member

The most recent CI run has zincati 0.0.26-2.fc40 -> 0.0.26-3.fc40 but there is one test still failing:

[2023-11-07T15:19:11.048Z] Nov 07 15:17:59 qemu0 kola-runext-kernel-replace[2135]: + ostree container encapsulate --repo=/ostree/repo 5cbfdf91992513ff67e9a49d01517d2c7606803679a3c06cff20d3e5d15d9c0b oci:/var/tmp/fcos
[2023-11-07T15:19:11.048Z] Nov 07 15:19:02 qemu0 kola-runext-kernel-replace[2214]: sha256:874d67e623e684fcc4553ba365064cce33fa8f72d1c34b77132e17bde8ca4b92
[2023-11-07T15:19:11.048Z] Nov 07 15:19:02 qemu0 kola-runext-kernel-replace[2135]: + rpm-ostree rebase --experimental ostree-unverified-image:oci:/var/tmp/fcos
[2023-11-07T15:19:11.048Z] Nov 07 15:19:02 qemu0 kola-runext-kernel-replace[2229]: Pulling manifest: ostree-unverified-image:oci:/var/tmp/fcos
[2023-11-07T15:19:11.048Z] Nov 07 15:19:03 qemu0 kola-runext-kernel-replace[2229]: error: Preparing import: Fetching manifest: Target image does not have ostree.bootable label
[2023-11-07T15:19:11.048Z] Nov 07 15:19:03 qemu0 systemd[1]: kola-runext.service: Main process exited, code=exited, status=1/FAILURE
[2023-11-07T15:19:11.048Z] Nov 07 15:19:03 qemu0 systemd[1]: kola-runext.service: Failed with result 'exit-code'.
[2023-11-07T15:19:11.048Z] Nov 07 15:19:03 qemu0 systemd[1]: kola-runext.service: Consumed 1min 884ms CPU time.
[2023-11-07T15:19:11.048Z] --- FAIL: ext.config.rpm-ostree.kernel-replace (92.52s)

@cgwalters
Copy link
Member Author

OK split out the test fix into #2729

dustymabe
dustymabe previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still LGTM, but the GH web UI is complaining about conflicts that will prevent merge.

@cgwalters @dustymabe
[rawhide] Switch to deploying via container image
fa0b41c 
Because rawhide is a mechanical stream, this won't break anything
for production streams.  It will help shake out anything
that might be broken by this.
@dustymabe
Copy link
Member

dustymabe commented Nov 14, 2023 •
edited

ok I think I fixed the merge conflict and rebased on top of latest rawhide

jlebon
jlebon approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@jlebon jlebon merged commit 35a9823 into coreos:rawhide Nov 14, 2023
1 check passed
@cgwalters
Copy link
Member Author

Thanks! Let's keep an eye out for fallout.

@dustymabe
Copy link
Member

🔍 👀

@gursewak1997 gursewak1997 mentioned this pull request Nov 17, 2023
Closed
@dustymabe dustymabe mentioned this pull request Jan 3, 2024
Closed
@dustymabe dustymabe mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cgwalters @dustymabe @jlebon