Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] tree: promote changes from testing at b374b765d90e3a2f8ae2ac373c934424fc152d3a #2716

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

coreosbot-releng
Copy link

@dustymabe
Copy link
Member

Hmm. so this is actually not right. We pre-emptively promoted testing from next in #2710 last Friday when the content set for GA was finalized and that messes up the flow here.

What we need to do is promote from b374b76 which was the last testing release. I can fix this up locally and push here.

@dustymabe dustymabe changed the title [stable] tree: promote changes from testing at 7e2d1e47aa9dde5e918c879b20dd071e9dacd8da [stable] tree: promote changes from testing at b374b765d90e3a2f8ae2ac373c934424fc152d3a Nov 6, 2023
@dustymabe
Copy link
Member

I can fix this up locally and push here.

Done

@marmijo
Copy link
Member

marmijo commented Nov 6, 2023

check promotion diffs is failing because the original promotion in this PR was from a different commit.

env:
    COMMIT_TITLE: [stable] tree: promote changes from testing at 7e2d1e47aa9dde

I tried to rerun it but it didn't pick up the new commit.

@marmijo
Copy link
Member

marmijo commented Nov 6, 2023

It doesnt seem like the check promotion diffs job is picking up the new commit from the PR title. I've manually checked the diff between b374b76 and coreosbot-releng@2c8b888:

diff --git a/manifest.yaml b/manifest.yaml
index fbb095f3..c8b774aa 100644
--- a/manifest.yaml
+++ b/manifest.yaml
@@ -1,5 +1,5 @@
 variables:
-  stream: stable
+  stream: testing
   prod: true
 
 releasever: 38

@marmijo marmijo merged commit 045166b into coreos:stable Nov 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants