Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] overrides: pin rust-zincati-0.0.25-4.fc38 #2720

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[stable] overrides: pin rust-zincati-0.0.25-4.fc38 #2720

merged 1 commit into from
Nov 8, 2023

Conversation

coreosbot-releng
Copy link

Requested by @dustymabe via GitHub workflow (source).

@dustymabe dustymabe enabled auto-merge (rebase) November 8, 2023 00:46
@dustymabe dustymabe mentioned this pull request Nov 8, 2023
Closed
@dustymabe
Copy link
Member

CI failed with:

[2023-11-08T02:16:06.105Z] ostree diff commit from: f072777dcbc3b64088b021283a2f719af516171595a8fb88cc17d4dcc87ad995
[2023-11-08T02:16:06.105Z] ostree diff commit to:   b9013a562c22c99f10328939b4641e354821a02a3e7e31601358f33e695098e9
[2023-11-08T02:16:06.105Z] Downgraded:
[2023-11-08T02:16:06.105Z]   zincati 0.0.26-2.fc38 -> 0.0.25-4.fc38
[2023-11-08T02:16:06.105Z] + grep -q Downgraded tmp/diff.txt
[2023-11-08T02:16:06.105Z] + echo 'Downgrade detected. This is likely unintentional. If not, you may safely ignore this error.'
[2023-11-08T02:16:06.105Z] Downgrade detected. This is likely unintentional. If not, you may safely ignore this error.

which is the point of this PR so we'll ignore the error.

@dustymabe
Copy link
Member

I'll cheat and post a review :)

dustymabe
dustymabe approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit ab4907d into coreos:stable Nov 8, 2023
1 of 2 checks passed
jlebon
jlebon reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but before we release this, let's sanity-check that it indeed doesn't hit coreos/fedora-coreos-tracker#1608.

@dustymabe dustymabe mentioned this pull request Nov 8, 2023
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coreosbot-releng @dustymabe @jlebon @coreosbot