Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: verify systemd-sysuser.service with ConditionNeedsUpdate= will be triggered with new deployment #2725

Merged

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei changed the title tests: verify systemd-sysuser.service will be triggered with new deployment tests: verify systemd-sysuser.service with ConditionNeedsUpdate= will be triggered with new deployment Nov 9, 2023
jlebon
jlebon previously approved these changes Nov 13, 2023
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks!

tests/kola/systemd/condition-needs-update Show resolved Hide resolved
tests/kola/systemd/condition-needs-update Show resolved Hide resolved
tests/kola/systemd/condition-needs-update Outdated Show resolved Hide resolved
@HuijingHei HuijingHei merged commit 0b50084 into coreos:testing-devel Nov 14, 2023
3 checks passed
@HuijingHei HuijingHei deleted the test-condition-needs-update branch November 14, 2023 14:21
@HuijingHei
Copy link
Member Author

Thanks @jlebon for the review!

@travier
Copy link
Member

travier commented Nov 20, 2023

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants