Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enabling iiso-offline-install-iscsi.bios #2800

Closed
wants to merge 1 commit into from

Conversation

jbtrystram
Copy link
Contributor

Multi arch images are available now at quay.io/jbtrystram/targetcli so we can re-enable this test.

This requires further work still, tracked in coreos/fedora-coreos-tracker#1639 Fixes coreos/fedora-coreos-tracker#1638

Multi arch images are available now at quay.io/jbtrystram/targetcli so
we can re-enable this test.
This requires further work still, tracked in coreos/fedora-coreos-tracker#1639
Fixes coreos/fedora-coreos-tracker#1638
@jlebon
Copy link
Member

jlebon commented Jan 15, 2024

Did you verify that the test passes on multi-arch?

@dustymabe
Copy link
Member

Multi arch images are available now at quay.io/jbtrystram/targetcli so we can re-enable this test.

I feel like if we re-enable the tests without the work being done to build in our pipeline and push to a shared organization namespace we won't have much incentive to go back and complete that work.

@jlebon
Copy link
Member

jlebon commented Jan 15, 2024

Hmm, it looks like x86_64 is failing?

I feel like if we re-enable the tests without the work being done to build in our pipeline and push to a shared organization namespace we won't have much incentive to go back and complete that work.

I understand the worry, though my main concern above coreos/fedora-coreos-tracker#1639 is to actually have iSCSI coverage in CI as soon as possible. That said, we did also talk about coreos/fedora-coreos-tracker#1639 this morning in planning and it's in the current sprint.

As a middle-ground, I'd be OK having it active just on x86_64 for now until coreos/fedora-coreos-tracker#1639 is done. So then this PR would just be about un-denylisting just x86_64.

@dustymabe
Copy link
Member

I understand the worry, though my main concern above coreos/fedora-coreos-tracker#1639 is to actually have iSCSI coverage in CI as soon as possible. That said, we did also talk about coreos/fedora-coreos-tracker#1639 this morning in planning and it's in the current sprint.

ok yeah, getting it in CI is important enough to me. Feel free to proceed.

@jbtrystram
Copy link
Contributor Author

Closing this one in favor of #2816
As i can't force push here. Sorry for pushing a branch on that repo in the first place !

@jbtrystram jbtrystram closed this Jan 23, 2024
@travier travier deleted the enable-iscsi-test branch February 2, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing multi-arches images for iso-offline-install-iscsi.bios
3 participants