Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live ISO: extend boot prompt timeout to 5 seconds #281

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

dustymabe
Copy link
Member

At 1 second it's almost impossible to catch the boot prompt if you need
to change the kernel command line parameters. Let's extend it to 5 seconds
so users have a fighting chance to catch the prompt.

At 1 second it's almost impossible to catch the boot prompt if you need
to change the kernel command line parameters. Let's extend it to 5 seconds
so users have a fighting chance to catch the prompt.
Copy link

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will definitely make users' lives easier.

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally set it at one second under the theory that users shouldn't need to mess with kargs. But with the static IP stuff and the possibility of coreos.inst usage, I think that was probably optimistic.

@dustymabe dustymabe merged commit d6bc990 into coreos:testing-devel Feb 7, 2020
@dustymabe dustymabe deleted the dusty branch February 8, 2020 23:07
dustymabe added a commit to dustymabe/coreos-assembler that referenced this pull request Mar 19, 2020
At 1 second it's almost impossible to catch the boot prompt if you need
to change the kernel command line parameters. Let's extend it to 5
seconds so users have a fighting chance to catch the prompt.

This follows from a similar change made to the Live ISO:
coreos/fedora-coreos-config#281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants