05core: skip sysroot.mount for remote kdump #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would an alternative approach to this be to just make sure the XFS module gets loaded in the initramfs? |
|
It's what I suggested on https://issues.redhat.com/browse/OCPBUGS-27935 |
jlebon
previously approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Yeah, this is not ideal but at least it's contained.
I think the real fix here is probably a barrier release to finally migrate older systems to add a root karg, and then we'd change the logic here to only emit sysroot.mount on first boot (i.e. move it below the ignition.firstboot check).
|
another option would be to convince kdump upstream to name the module in their default config. but if we want to do the |
|
I am not so sure about I should do here , after reading comments from @dustymabe and @jlebon :) |
|
IMO I think we should get this in to unbreak anyone using kdump+SSH. Doing the migration is good too, but must be done carefully. How about filing a tracker issue for the migration and then linking that as a comment in the code mentioning that we'll be able to clean this up once it's implemented? |
jbtrystram
force-pushed
the
kdump-xfs
branch
from
fe98920
to
912ebea
Compare
Ok, I updated the commit message and also add a link in the code |
If kdump is setup to upload logs to a remote host, the XFS module may not be loaded, which cause sysroot.mount to fail. If the target for logs is SSH, kdump will boot with a `kdump_remote_ip` karg. Skip generating sysroot.mount in that case so kdump can boot without having to load XFS. This is a temporary fix until we migrate older systems to have a root karg: coreos/fedora-coreos-tracker#1675 See https://issues.redhat.com/browse/OCPBUGS-27935
jbtrystram
force-pushed
the
kdump-xfs
branch
from
912ebea
to
fd3cd17
Compare
jlebon
approved these changes
Feb 17, 2024
|
We can not rely on loading the right filesystem module as kdump maybe be used in a "diskless" / upload to remote mode which will not touch the disks at all, for example if those are LUKS encrypted. |
This was referenced Feb 21, 2024
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 8, 2024
See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Adding this as a condition to the sysroot.mount generator makes systemd skip the mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-27935
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 8, 2024
See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Adding this as a condition to the sysroot.mount generator makes systemd skip the mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 11, 2024
See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 11, 2024
See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 12, 2024
See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 12, 2024
Further refines 1d757f4 See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 12, 2024
Further refines 1d757f4 See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
that referenced
this pull request
Mar 12, 2024
Further refines 1d757f4 See #2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 13, 2024
Further refines 1d757f4 See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
that referenced
this pull request
Mar 13, 2024
Further refines 1d757f4 See #2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Mar 13, 2024
Further refines 1d757f4 See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
jbtrystram
added a commit
that referenced
this pull request
Mar 13, 2024
Further refines 1d757f4 See #2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Mar 18, 2024
Further refines 1d757f4 See coreos#2847 This one was merged with not enough testing : it turns out the kernel arg is only visible to dracut, which turns it into a drop-in file, in /etc/cmdline.d/60kdumpip.conf Use the dracut lib to query the "kdump_remote_ip" argument to skip the sysroot mount unit in kdump initramfs (only when kdump is configured to export logs to a remote IP) Ref https://issues.redhat.com/browse/OCPBUGS-29762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kdump is setup to upload logs to a remote host, the XFS module may not be loaded, which cause sysroot.mount to fail.
If the target for logs is SSH, kdump will boot with a
kdump_remote_ipkarg. Skip generating sysroot.mount in that case so kdump can boot without having to load XFS.See https://issues.redhat.com/browse/OCPBUGS-27935