Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: drop containernetworking-plugins and podman-plugins #2852

Merged

Conversation

gursewak1997
Copy link
Member

Since podman is dropping support for CNI networking entirely we can drop containernetworking-plugins and podman-plugins. Podman stopped shipping podman-plugins rpm with the Podmanv5. Subsequently, we wouldn't need containernetworking-plugins as it is just libraries for writing CNI plugins.
Ref: coreos/fedora-coreos-tracker#1629 (comment)

@jlebon
Copy link
Member

jlebon commented Feb 13, 2024

This needs to be made conditional on Fedora 40. Or in other words, you would move the containernetworking-plugins and podman-plugins bits to a separate manifest, and add a conditional include for f39 for that manifest. Grep for conditional-include to see examples of this.

Also /cc @mheon to sanity-check: there's no point in having these packages in f40, right?

@mheon
Copy link

mheon commented Feb 13, 2024

Podman-plugins we definitely have no further use for. Containernetworking-plugins is still used by CRI-O but I'm not sure how that ships in Fedora

@jlebon
Copy link
Member

jlebon commented Feb 13, 2024

Podman-plugins we definitely have no further use for. Containernetworking-plugins is still used by CRI-O but I'm not sure how that ships in Fedora

Ack, thanks.

Looks like the CRI-O in Fedora Suggests it. Since CRI-O currently needs to be layered separately, I think we could also have any users doing that also layer this if they need it. We should mention it as part of our f40 communications.

@gursewak1997 gursewak1997 force-pushed the update-manifest-podmanv5 branch from ee0ac0f to 0184e45 Compare February 13, 2024 18:21
dustymabe
dustymabe previously approved these changes Feb 13, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion. otherwise LGTM

@@ -0,0 +1,4 @@
# Issue: https://github.com/coreos/fedora-coreos-config/pull/2818
# Delete this file once Podman v5 releases to f39
Copy link
Member

@dustymabe dustymabe Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman v5 will never go to F39.

Suggested change
# Delete this file once Podman v5 releases to f39
# Delete this file once we are on Podman v5 everywhere.
# i.e. We have moved past F39.

@gursewak1997 gursewak1997 force-pushed the update-manifest-podmanv5 branch from 8880b5a to c35ec5c Compare February 13, 2024 19:52
Since podman is dropping support for CNI networking entirely
we can drop containernetworking-plugins and  podman-plugins.
Podman stopped shipping podman-plugins rpm with the Podmanv5.
Subsequently, we wouldn't need containernetworking-plugins as
it is just libraries for writing CNI plugins.
@gursewak1997 gursewak1997 force-pushed the update-manifest-podmanv5 branch from c35ec5c to a7b43c9 Compare February 13, 2024 19:54
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) February 13, 2024 19:55
@dustymabe dustymabe merged commit 6f073a2 into coreos:testing-devel Feb 13, 2024
3 checks passed
@gursewak1997 gursewak1997 deleted the update-manifest-podmanv5 branch February 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants