-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: drop containernetworking-plugins
and podman-plugins
#2852
manifest: drop containernetworking-plugins
and podman-plugins
#2852
Conversation
This needs to be made conditional on Fedora 40. Or in other words, you would move the Also /cc @mheon to sanity-check: there's no point in having these packages in f40, right? |
Podman-plugins we definitely have no further use for. Containernetworking-plugins is still used by CRI-O but I'm not sure how that ships in Fedora |
Ack, thanks. Looks like the CRI-O in Fedora |
ee0ac0f
to
0184e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion. otherwise LGTM
0184e45
to
8880b5a
Compare
manifests/cni-plugins.yaml
Outdated
@@ -0,0 +1,4 @@ | |||
# Issue: https://github.com/coreos/fedora-coreos-config/pull/2818 | |||
# Delete this file once Podman v5 releases to f39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
podman v5 will never go to F39.
# Delete this file once Podman v5 releases to f39 | |
# Delete this file once we are on Podman v5 everywhere. | |
# i.e. We have moved past F39. |
8880b5a
to
c35ec5c
Compare
Since podman is dropping support for CNI networking entirely we can drop containernetworking-plugins and podman-plugins. Podman stopped shipping podman-plugins rpm with the Podmanv5. Subsequently, we wouldn't need containernetworking-plugins as it is just libraries for writing CNI plugins.
c35ec5c
to
a7b43c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since podman is dropping support for CNI networking entirely we can drop
containernetworking-plugins
andpodman-plugins
. Podman stopped shippingpodman-plugins
rpm with the Podmanv5. Subsequently, we wouldn't needcontainernetworking-plugins
as it is just libraries for writing CNI plugins.Ref: coreos/fedora-coreos-tracker#1629 (comment)