Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating next-devel manifest for f40 #2901

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Updating next-devel manifest for f40 #2901

merged 3 commits into from
Mar 19, 2024

Conversation

aaradhak
Copy link
Member

@github-actions GitHub Actions
Copy link

⛔ The next-devel branch is currently closed. PRs should target only testing-devel.

@aaradhak aaradhak requested a review from dustymabe March 15, 2024 16:31
dustymabe
dustymabe previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

though in order to get CI to pass I think you need to follow the step in coreos/fedora-coreos-tracker#1674 to update the x86_64 lockfile.

@aaradhak aaradhak force-pushed the next-devel-ar branch 2 times, most recently from 8184a1b to beddba4 Compare March 18, 2024 14:44
@aaradhak aaradhak requested a review from dustymabe March 18, 2024 14:45
@aaradhak
Copy link
Member Author

though in order to get CI to pass I think you need to follow the step in coreos/fedora-coreos-tracker#1674 to update the x86_64 lockfile.

The manifest lockfile has been updated.

dustymabe
dustymabe previously approved these changes Mar 18, 2024
View reviewed changes
@dustymabe
Copy link
Member

and now CI is failing because of coreos/fedora-coreos-tracker#1694

can you just drop the addition of the candidate compose repo here and we'll add it in a followup PR.

@dustymabe
Copy link
Member

can you just drop the addition of the candidate compose repo here and we'll add it in a followup PR.

or actually, just go ahead and add an override to pin on the old version of shim like I did in #2904

dustymabe
dustymabe approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaradhak
Copy link
Member Author

can you just drop the addition of the candidate compose repo here and we'll add it in a followup PR.

or actually, just go ahead and add an override to pin on the old version of shim like I did in #2904

ok the overrides are added.

@aaradhak aaradhak requested a review from dustymabe March 18, 2024 17:34
@aaradhak aaradhak enabled auto-merge (rebase) March 18, 2024 18:28
@aaradhak
Copy link
Member Author

The kola test ext.config.var-mount.scsi-id fails in the CI.

@dustymabe
Copy link
Member

The kola test ext.config.var-mount.scsi-id fails in the CI.

guess we'll need to add next and next-devel to the list in the kola-denylist.yaml on the testing-devel branch. Open a new PR for that.

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this pull request Mar 18, 2024
@aaradhak
denylist: snooze ext.config.var-mount.scsi-id on next & next-devel
ad408de 
Let's also snooze `ext.config.var-mount.scsi-id` on next & next-devel
since it's been failing on F40.
Ref: coreos#2901
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this pull request Mar 18, 2024
@aaradhak
denylist: snooze ext.config.var-mount.scsi-id on next & next-devel
5fe6e3b 
Let's also snooze `ext.config.var-mount.scsi-id` on next & next-devel
since it's been failing on F40.
Ref: coreos#2901
@aaradhak aaradhak mentioned this pull request Mar 18, 2024
Merged
aaradhak added a commit that referenced this pull request Mar 18, 2024
@aaradhak
denylist: snooze ext.config.var-mount.scsi-id on next & next-devel
8088972 
Let's also snooze `ext.config.var-mount.scsi-id` on next & next-devel
since it's been failing on F40.
Ref: #2901
@aaradhak aaradhak disabled auto-merge March 18, 2024 22:11
@aaradhak aaradhak enabled auto-merge (rebase) March 18, 2024 22:24
@aaradhak aaradhak mentioned this pull request Mar 18, 2024
Closed
52 tasks
@aaradhak aaradhak merged commit e9052c0 into coreos:next-devel Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaradhak @dustymabe