[next] tree: promote changes from next-devel at 781a9bba27b52a79979d7cb6f42df381a6cf32ed #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreosbot-releng
force-pushed
the
next-promotion
branch
from
5d118b8
to
dc1e961
Compare
dustymabe
reviewed
Apr 1, 2024
| @@ -20,3 +20,12 @@ | |||
| - branched | |||
| - next | |||
| - next-devel | |||
| - pattern: coreos.boot-mirror* | |||
| tracker: https://github.com/coreos/fedora-coreos-tracker/issues/1659 | |||
| # warn: true (disabled on promotion) | |||
There was a problem hiding this comment.
this is purely commentary:
The intent of commenting these out was to make the "snooze" lines not have any effect (i.e. disallowing them to expire) on production streams, but I think in the case where we encounter a warn with no snooze we should leave it in the future.
Now, warn with no snooze isn't really something we've commonly done, but in this case we did do it on purpose.
Might PR this if I get a chance or someone else feel free.
marmijo
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by @marmijo in coreos/fedora-coreos-streams#872.