tests/manual: add in coreos-builds-bisect script #2961
Conversation
This script will allow us to perform bisection on our list of builds for our CoreOS streams. It will enable us to find issues faster. It was inspired by rpm-ostree-bisect [1], which does somethign similar, but operates on the OSTree repo from inside the OS. Example output looks something like: ``` + echo 'Could not access /etc/shadow -> SUCCESS' Could not access /etc/shadow -> SUCCESS + exit 0 38.20230819.3.0 passed BISECT TEST RESULTS: Last known good build: 38.20230819.3.0 First known bad build: 38.20230902.3.0 ``` [1] https://github.com/ostreedev/ostree-releng-scripts/blob/master/rpm-ostree-bisecthis
dustymabe
force-pushed
the
dusty-coreos-builds-bisect
branch
from
772b058
to
dd857cd
Compare
There was a problem hiding this comment.
I didn't review the script in depth, but it looks sane to me!
Though I wonder if it should be in e.g. tests/tools/ or tests/scripts/ instead? All the other files in tests/manual/ currently are actual scripts that test specific features and so are accurately described by the directory name. This seems like a more generic tool?
I don't have a strong opinion there. Mostly the things in here are here because we didn't have a better place to put them and you generally know what you are looking for if you get down this far.. With as few of these that there are I'm not sure making other directories will add value (i.e. compared to the more searching) until we get into maybe 10s of files? TL;DR Want it in a |
Actually yeah, |
|
I'll keep it where it is for now just to save a CI cycle. Thanks for the review! |
This will allow one to just specify a build ID rather than having to specify both the stream the build was on and the build ID. This will make things slightly more convenient for things like coreos-builds-bisect [1] where the called script now doesn't need to know what stream we are on. [1] coreos/fedora-coreos-config#2961
This will allow one to just specify a build ID rather than having to specify both the stream the build was on and the build ID. This will make things slightly more convenient for things like coreos-builds-bisect [1] where the called script now doesn't need to know what stream we are on. [1] coreos/fedora-coreos-config#2961
This will allow one to just specify a build ID rather than having to specify both the stream the build was on and the build ID. This will make things slightly more convenient for things like coreos-builds-bisect [1] where the called script now doesn't need to know what stream we are on. [1] coreos/fedora-coreos-config#2961
This script will allow us to perform bisection on our list of builds for our CoreOS streams. It will enable us to find issues faster. It was inspired by rpm-ostree-bisect [1], which does somethign similar, but operates on the OSTree repo from inside the OS.
Example output looks something like:
[1] https://github.com/ostreedev/ostree-releng-scripts/blob/master/rpm-ostree-bisecthis