overlay/growfs: support CEX-encrypted LUKS volumes #2986

madhu-pillai · 2024-04-25T13:13:31Z

Support for CEX LUKS volumes was added in Ignition as part of
coreos/ignition#1693.

jlebon · 2024-04-25T21:12:19Z

Hmm, can you provide the Ignition config you're testing with? Has Ignition already resized the partition?

I would think in the general case we do still need to call cryptsetup resize (and so the patch here would instead detect the CEX case and get the hardcoded keyfile from /etc/).

madhu-pillai · 2024-04-26T03:30:42Z

Hmm, can you provide the Ignition config you're testing with? Has Ignition already resized the partition?

I would think in the general case we do still need to call cryptsetup resize (and so the patch here would instead detect the CEX case and get the hardcoded keyfile from /etc/).

Hi, Here is the ignition config.

cat /var/www/html/ignition/dasdconfig.ign 
{
  "ignition": {
    "version": "3.5.0-experimental"
  }, 
  "kernelArguments": {
    "shouldExist": [
      "rd.luks.key=/etc/luks/cex.key"
    ]
  },
  "passwd": {
    "users": [
      {
        "name": "core",
        "sshAuthorizedKeys": [
          "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJLw9d5d0DRkK6yJGnbTlD6IXu7NX2puMhPor3oTjIOv ignition"
        ]
      }
    ]
  },
  "storage": {
    "files": [
      {
        "path": "/etc/sshd/sshd_config.d/20-enable-passwords.conf",
        "contents": {
          "compression": "",
          "source": "data:,PasswordAuthentication%20yes%0A"
        },
        "mode": 420
      }
    ],
    "filesystems": [
      {
        "device": "/dev/mapper/root",
        "format": "ext4",
        "label": "root",
        "wipeFilesystem": true
      }
    ],
    "luks": [
      {
 	"cex": {
		"enabled": true
	},
        "device": "/dev/dasda2",
        "name": "root",
        "wipeVolume": true
      }
    ]
  }
}

madhu-pillai · 2024-04-26T11:08:49Z

Hi @jlebon ,
I've add the following line for the growfs and tested with both ext4 and xfs. Attached the log for the reference.
growfs_xfs.txt

 crypt)
           DASD_CEX=$(lsblk -o KNAME | grep dasd[a-z]2)
           if [[ -n ${DASD_CEX} && $(cryptsetup luksDump /dev/${DASD_CEX} | grep -w "paes-verification-pattern") ]]
           then
                   #echo "Skipping Cex encrypted dasd device" 1>&2
                   if ! cryptsetup resize root --key-file /etc/luks/cex.key ; then
                           echo "error: Resize failed on Cex Encrypted device"
                           exit 0
                   fi
           else
            # XXX: yuck... we need to expose this sanely in clevis
            (. /usr/bin/clevis-luks-common-functions
             eval $(udevadm info --query=property --export "${NAME}")
             # lsblk doesn't print PKNAME of crypt devices with --nodeps
             PKNAME=/dev/$(ls "/sys/dev/block/${MAJMIN}/slaves")
             clevis_luks_unlock_device "${PKNAME}" | cryptsetup resize -d- "${DM_NAME}"
            )
            fi
            ;;
        # already checked
        *) echo "unreachable" 1>&2; exit 1 ;;

jlebon · 2024-05-20T13:19:46Z

Hi @madhu-pillai,

I've reworked this to fix some issues and clean things up a bit. WDYT? If it looks good, can you also check that the CEX case still works fine?

madhu-pillai · 2024-05-21T04:59:48Z

Hi @jlebon ,
Sorry i was on leave yesterday. Working on this now and update you soon.

madhu-pillai · 2024-05-21T14:55:30Z

Hi @jlebon , I've tested in the dasd and it worked both with xfs and ext4. snippet is below.

[   55.977663] ignition[1062]: disks: createLuks: op(1): [finished] waiting for devices [/dev/dasda2]
[   55.977830] ignition[1062]: disks: createLuks: created device alias for "/dev/dasda2": "/run/ignition/dev_aliases/dev/dasda2" -> "/dev/dasda2"
[   55.977987] ignition[1062]: disks: createLuks: op(2): [started]  wiping filesystem signatures from "/run/ignition/dev_aliases/dev/dasda2"
[   55.989288] ignition[1062]: disks: createLuks: op(2): [finished] wiping filesystem signatures from "/run/ignition/dev_aliases/dev/dasda2"
[   55.990547] ignition[1062]: disks: createLuks: op(3): [started]  generating cex secure keys
[   56.056871] ignition[1062]: disks: createLuks: op(3): [finished] generating cex secure keys
[   56.056945] ignition[1062]: disks: createLuks: op(4): [started]  creating "root"
[   71.150480] ignition[1062]: disks: createLuks: op(4): [finished] creating "root"
[   71.150580] ignition[1062]: disks: createLuks: op(5): [started]  Setting verification pattern for device: "/run/ignition/dev_aliases/dev/dasda2"
[   73.542365] ignition[1062]: disks: createLuks: op(5): [finished] Setting verification pattern for device: "/run/ignition/dev_aliases/dev/dasda2"
[   73.542465] ignition[1062]: disks: createLuks: op(6): [started]  opening luks device root
[   75.806451] ignition[1062]: disks: createLuks: op(6): [finished] opening luks device root
[   75.807277] ignition[1062]: disks: createLuks: op(7): [started]  waiting for triggered uevent
[   75.838178] ignition[1062]: disks: createLuks: op(7): [finished] waiting for triggered uevent
[   75.838251] ignition[1062]: disks: createFilesystems: op(8): [started]  waiting for devices [/dev/mapper/root]
[   75.845512] ignition[1062]: disks: createFilesystems: op(8): [finished] waiting for devices [/dev/mapper/root]
[   75.845564] ignition[1062]: disks: createFilesystems: created device alias for "/dev/mapper/root": "/run/ignition/dev_aliases/dev/mapper/root" -> "/dev/d
[   75.845619] ignition[1062]: disks: createFilesystems: op(9): [started]  determining filesystem type of "/dev/mapper/root"
[   75.878194] ignition[1062]: disks: createFilesystems: op(9): [finished] determining filesystem type of "/dev/mapper/root"
[   75.878279] ignition[1062]: disks: createFilesystems: found  filesystem at "/dev/mapper/root" with uuid "" and label ""
[   75.878302] ignition[1062]: disks: createFilesystems: op(a): [started]  wiping filesystem signatures from "/run/ignition/dev_aliases/dev/mapper/root"
[   75.891036] ignition[1062]: disks: createFilesystems: op(a): [finished] wiping filesystem signatures from "/run/ignition/dev_aliases/dev/mapper/root"
[   75.891084] ignition[1062]: disks: createFilesystems: op(b): [started]  creating "xfs" filesystem on "/run/ignition/dev_aliases/dev/mapper/root"
[   76.271132] ignition[1062]: disks: createFilesystems: op(b): [finished] creating "xfs" filesystem on "/run/ignition/dev_aliases/dev/mapper/root"
[   76.271226] ignition[1062]: disks: createFilesystems: op(c): [started]  waiting for triggered uevent
[   76.321592] ignition[1062]: disks: createFilesystems: op(c): [finished] waiting for triggered uevent
[   76.321661] ignition[1062]: disks: disks passed
[   76.327251] ignition[1062]: Ignition finished successfully
[   76.331821] systemd[1]: Finished Ignition (disks).
[   76.334008] systemd[1]: Reached target Initrd Root Device.
[   76.376981] systemd[1]: Starting CoreOS Ensure Unique Boot Filesystem...
[   76.640641] systemd[1]: Finished CoreOS Ensure Unique Boot Filesystem.
[   76.641067] systemd[1]: Ignition OSTree: Regenerate Filesystem UUID (root) was skipped because of an unmet condition check (ConditionPathExists=!/run/ign
[   76.686736] systemd[1]: Starting Ignition OSTree: Grow Root Filesystem...
[   76.686810] systemd[1]: Afterburn (Check In - from the initramfs) was skipped because of an unmet condition check (ConditionKernelCommandLine=ignition.pl
[   76.718032] XFS (dm-0): Mounting V5 Filesystem aa25dc05-9697-422b-b3b3-7d8fb28fc1e9
[   76.735639] XFS (dm-0): Ending clean mount
[   76.800834] ignition-ostree-growfs[1244]: WARN: unknown label
[   76.808550] ignition-ostree-growfs[1244]: failed [sfd_dump:1] sfdisk --unit=S --dump /dev/dasda
[   76.809121] ignition-ostree-growfs[1264]: sfdisk: /dev/dasda: does not contain a recognized partition table
[   76.809182] ignition-ostree-growfs[1244]: FAILED: failed to dump sfdisk info for /dev/dasda
[   78.991893] ignition-ostree-growfs[1291]: meta-data=/dev/mapper/root       isize=512    agcount=4, agsize=6335189 blks
[   78.991951] ignition-ostree-growfs[1291]:          =                       sectsz=4096  attr=2, projid32bit=1
[   78.991967] ignition-ostree-growfs[1291]:          =                       crc=1        finobt=1, sparse=1, rmapbt=0
[   78.991982] ignition-ostree-growfs[1291]:          =                       reflink=1    bigtime=1 inobtcount=1 nrext64=0
[   78.991996] ignition-ostree-growfs[1291]: data     =                       bsize=4096   blocks=25340756, imaxpct=25
[   78.992009] ignition-ostree-growfs[1291]:          =                       sunit=0      swidth=0 blks
[   78.992024] ignition-ostree-growfs[1291]: naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
[   78.992038] ignition-ostree-growfs[1291]: log      =internal log           bsize=4096   blocks=16384, version=2
[   78.992051] ignition-ostree-growfs[1291]:          =                       sectsz=4096  sunit=1 blks, lazy-count=1
[   78.992070] ignition-ostree-growfs[1291]: realtime =none                   extsz=4096   blocks=0, rtextents=0
[   78.994887] XFS (dm-0): Unmounting Filesystem aa25dc05-9697-422b-b3b3-7d8fb28fc1e9
[   78.997657] systemd[1]: Finished Ignition OSTree: Grow Root Filesystem.
[   79.059449] systemd[1]: Starting Ignition OSTree: Autosave XFS Rootfs Partition...
[   79.074139] ignition-ostree-transposefs[1321]: autosave-xfs: /dev/disk/by-label/root agcount=4 is lower than threshold=400
[   79.074682] systemd[1]: Finished Ignition OSTree: Autosave XFS Rootfs Partition.
[   79.077367] systemd[1]: Starting Ignition OSTree: Restore Partitions...
[   79.082160] ignition-ostree-transposefs[1334]: Restoring rootfs from RAM...
[   79.091207] ignition-ostree-transposefs[1334]: Mounting /dev/disk/by-label/root rw (/dev/dm-0) to /sysroot
[   79.105530] XFS (dm-0): Mounting V5 Filesystem aa25dc05-9697-422b-b3b3-7d8fb28fc1e9
[   79.128307] XFS (dm-0): Ending clean mount

jlebon · 2024-05-21T16:51:16Z

[   76.800834] ignition-ostree-growfs[1244]: WARN: unknown label
[   76.808550] ignition-ostree-growfs[1244]: failed [sfd_dump:1] sfdisk --unit=S --dump /dev/dasda
[   76.809121] ignition-ostree-growfs[1264]: sfdisk: /dev/dasda: does not contain a recognized partition table
[   76.809182] ignition-ostree-growfs[1244]: FAILED: failed to dump sfdisk info for /dev/dasda

OK actually, there's another issue here. We're still calling growpart and it uses sfdisk which doesn't know what to do with DASD devices. This is not technically new and is independent of the CEX work, but let's fix it while you're set up for testing it.

Pushed another commit there. Can you retest it and confirm that the spurious output is gone? Also, can you show the output of df -h /sysroot?

madhu-pillai · 2024-05-22T15:15:55Z

Hi @jlebon,
I've tested and it works fine. Attached the dmesg log from setting the filesystem ext4 and xfs.

core@master-1 ~]$ df -h /sysroot
Filesystem        Size  Used Avail Use% Mounted on
/dev/mapper/root   97G  2.7G   94G   3% /sysroot

   66.948582] EXT4-fs (dm-0): mounted filesystem 26a5e003-c4c3-49a2-afc9-ac47d0af4627 r/w with ordered data mode. Quota mode: none.
[   66.978009] ignition-ostree-growfs[1245]: partition is on DASD device; skipping growpart
[   69.135511] ignition-ostree-growfs[1284]: resize2fs 1.46.5 (30-Dec-2021)
[   69.136049] ignition-ostree-growfs[1284]: The filesystem is already 25340756 (4k) blocks long.  Nothing to do!
[   69.137498] EXT4-fs (dm-0): unmounting filesystem 26a5e003-c4c3-49a2-afc9-ac47d0af4627.
[   69.141496] systemd[1]: Finished Ignition OSTree: Grow Root Filesystem.
[   69.176907] systemd[1]: Starting Ignition OSTree: Autosave XFS Rootfs Partition

[   68.615617] XFS (dm-0): Ending clean mount
[   68.647047] ignition-ostree-growfs[1216]: partition is on DASD device; skipping growpart
[   71.432415] ignition-ostree-growfs[1260]: meta-data=/dev/mapper/root       isize=512    agcount=4, agsize=6335189 blks
[   71.432678] ignition-ostree-growfs[1260]:          =                       sectsz=4096  attr=2, projid32bit=1
[   71.432710] ignition-ostree-growfs[1260]:          =                       crc=1        finobt=1, sparse=1, rmapbt=0
[   71.432731] ignition-ostree-growfs[1260]:          =                       reflink=1    bigtime=1 inobtcount=1 nrext64=0
[   71.432743] ignition-ostree-growfs[1260]: data     =                       bsize=4096   blocks=25340756, imaxpct=25
[   71.432756] ignition-ostree-growfs[1260]:          =                       sunit=0      swidth=0 blks
[   71.432767] ignition-ostree-growfs[1260]: naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
[   71.432778] ignition-ostree-growfs[1260]: log      =internal log           bsize=4096   blocks=16384, version=2
[   71.432789] ignition-ostree-growfs[1260]:          =                       sectsz=4096  sunit=1 blks, lazy-count=1
[   71.432799] ignition-ostree-growfs[1260]: realtime =none                   extsz=4096   blocks=0, rtextents=0
[   71.434156] XFS (dm-0): Unmounting Filesystem 29da0ae6-37b6-494e-b987-4cd02f3fdb14
[   71.439456] systemd[1]: Finished Ignition OSTree: Grow Root Filesystem.

Dasd_ext4.txt
Dasd_XFS.txt

jlebon · 2024-05-22T16:01:34Z

Great, thanks for testing!
Since I've also added commits here, let's get someone else to review this.

travier

Does not feel great to parse luksdump output using grep but I guess if we're doing that here, it's that we don't have a better option :/

Not tested but looks reasonable.

Support for CEX LUKS volumes was added in Ignition as part of coreos/ignition#1693. Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>

If the partition is on a DASD disk, then don't run growpart since it doesn't know how to handle it and it's not needed (coreos-installer already sizes it to its maximum).

It's cleaner and less prone to false positives.

jlebon · 2024-07-12T15:54:48Z

Thanks, good catch! I missed that in the original review, but indeed there's a --dump-json-metadata switch we can use instead here.

Added another commit, but also rebased while we're here to get a fresh CI run.

@madhu-pillai Can you retest the DASD and CEX cases with this?

madhu-pillai · 2024-07-12T16:02:03Z

Will do that.

madhu-pillai · 2024-07-13T17:46:28Z

Hi @jlebon ,
It works as expected in CEX mode. I've attached the full log herewith for the reference.

[core@master-1 ~]$ df -h /sysroot
Filesystem        Size  Used Avail Use% Mounted on
/dev/mapper/root   97G  2.7G   94G   3% /sysroot

[core@master-1 ~]$ lsblk -f
NAME     FSTYPE      FSVER LABEL UUID                                 FSAVAIL FSUSE% MOUNTPOINTS
dasda                                                                                
├─dasda1 ext4        1.0   boot  92e9120b-8cb7-4e12-8564-0ec4385101bc  247.2M    20% /boot
└─dasda2 crypto_LUKS 2           179004c0-f4c1-4443-bdc9-709ddd47f1b0                
  └─root xfs               root  eb38570c-1f11-4cb3-beb3-299bdef297cb   93.9G     3% /var
                                                                                     /sysroot/ostree/deploy/rhcos/var
                                                                                     /usr
                                                                                     /etc
                                                                                     /
                                                                                     /sysroot

Here is the verbose mode of the growfs.

[  129.902878] ignition-ostree-growfs[1230]:   "tokens":{
[  129.902893] ignition-ostree-growfs[1230]:     "0":{
[  129.902908] ignition-ostree-growfs[1230]:       "type":"paes-verification-pattern",
[  129.902922] ignition-ostree-growfs[1230]:       "keyslots":[
[  129.902936] ignition-ostree-growfs[1230]:       ],
[  129.903085] ignition-ostree-growfs[1230]:       "verification-pattern":"16f02df246c1164b82e0da060622f87607f46469331b5fb0e0b8daf8f281569f"
[  129.903196] ignition-ostree-growfs[1230]:     }
[  129.903213] ignition-ostree-growfs[1230]:   },
[  129.903227] ignition-ostree-growfs[1230]:   "segments":{
[  129.903242] ignition-ostree-growfs[1230]:     "0":{
[  129.903257] ignition-ostree-growfs[1230]:       "type":"crypt",
[  129.903420] ignition-ostree-growfs[1230]:       "offset":"16777216",
[  129.903670] ignition-ostree-growfs[1230]:       "size":"dynamic",
[  129.903692] ignition-ostree-growfs[1230]:       "iv_tweak":"0",
[  129.903707] ignition-ostree-growfs[1230]:       "encryption":"paes-xts-plain64",
[  129.903722] ignition-ostree-growfs[1230]:       "sector_size":4096
[  129.903737] ignition-ostree-growfs[1230]:     }
[  129.903751] ignition-ostree-growfs[1230]:   },
[  129.903765] ignition-ostree-growfs[1230]:   "digests":{
[  129.903780] ignition-ostree-growfs[1230]:     "0":{
[  129.903794] ignition-ostree-growfs[1230]:       "type":"pbkdf2",
[  129.903808] ignition-ostree-growfs[1230]:       "keyslots":[
[  129.903966] ignition-ostree-growfs[1230]:         "0"
[  129.903984] ignition-ostree-growfs[1230]:       ],
[  129.903999] ignition-ostree-growfs[1230]:       "segments":[
[  129.904018] ignition-ostree-growfs[1230]:         "0"
[  129.904144] ignition-ostree-growfs[1230]:       ],
[  129.904405] ignition-ostree-growfs[1230]:       "hash":"sha256",
[  129.904606] ignition-ostree-growfs[1230]:       "iterations":23744,
[  129.904714] ignition-ostree-growfs[1230]:       "salt":"e9TXB1tLWes5TLbk0SirVeqUv56bVpPQ2LZoYn6zITM=",
[  129.904735] ignition-ostree-growfs[1230]:       "digest":"Lo81VKVKPSy4yIqTMVOW8oioDxT+Dy2tGaoYOKVP+2I="
[  129.904750] ignition-ostree-growfs[1230]:     }
[  129.904765] ignition-ostree-growfs[1230]:   },
[  129.904779] ignition-ostree-growfs[1230]:   "config":{
[  129.904874] ignition-ostree-growfs[1230]:     "json_size":"12288",
[  129.904894] ignition-ostree-growfs[1230]:     "keyslots_size":"16744448",
[  129.904910] ignition-ostree-growfs[1230]:     "flags":[
[  129.904925] ignition-ostree-growfs[1230]:     ]
[  129.904939] ignition-ostree-growfs[1230]:   }
[  129.905123] ignition-ostree-growfs[1230]: }'
[  129.905152] ignition-ostree-growfs[1230]: + jq -e '[.tokens[].type] | index("clevis")'
[  129.907681] ignition-ostree-growfs[1268]: null
[  129.913238] ignition-ostree-growfs[1230]: + jq -e '.segments["0"].encryption | startswith("paes")'
[  129.913566] ignition-ostree-growfs[1269]: true
[  129.913676] ignition-ostree-growfs[1230]: + cryptsetup resize root --key-file /etc/luks/cex.key
[  134.865429] ignition-ostree-growfs[1230]: + holders=/sys/dev/block/253:0/holders
[  134.866190] ignition-ostree-growfs[1230]: + '[' -d /sys/dev/block/253:0/holders ']'
[  134.868702] ignition-ostree-growfs[1272]: ++ ls /sys/dev/block/253:0/holders
[  134.868855] ignition-ostree-growfs[1274]: ++ wc -l
[  134.869464] ignition-ostree-growfs[1230]: + nholders=0
[  134.869482] ignition-ostree-growfs[1230]: + '[' 0 -eq 0 ']'
[  134.872830] ignition-ostree-growfs[1230]: + break
[  134.872852] ignition-ostree-growfs[1230]: + wipefs -af -t noxfs /dev/disk/by-label/root
[  134.885354] ignition-ostree-growfs[1230]: + case "${ROOTFS_TYPE}" in
[  134.885396] ignition-ostree-growfs[1230]: + xfs_growfs /sysroot
[  134.891682] ignition-ostree-growfs[1276]: meta-data=/dev/mapper/root       isize=512    agcount=4, agsize=6335189 blks
[  134.891714] ignition-ostree-growfs[1276]:          =                       sectsz=4096  attr=2, projid32bit=1
[  134.891727] ignition-ostree-growfs[1276]:          =                       crc=1        finobt=1, sparse=1, rmapbt=0
[  134.891744] ignition-ostree-growfs[1276]:          =                       reflink=1    bigtime=1 inobtcount=1 nrext64=0
[  134.891756] ignition-ostree-growfs[1276]: data     =                       bsize=4096   blocks=25340756, imaxpct=25
[  134.891768] ignition-ostree-growfs[1276]:          =                       sunit=0      swidth=0 blks
[  134.891779] ignition-ostree-growfs[1276]: naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
[  134.891791] ignition-ostree-growfs[1276]: log      =internal log           bsize=4096   blocks=16384, version=2
[  134.891802] ignition-ostree-growfs[1276]:          =                       sectsz=4096  sunit=1 blks, lazy-count=1
[  134.891814] ignition-ostree-growfs[1276]: realtime =none                   extsz=4096   blocks=0, rtextents=0
[  134.891831] ignition-ostree-growfs[1230]: + touch /run/ignition-ostree-growfs.stamp
[  134.903179] XFS (dm-0): Unmounting Filesystem eb38570c-1f11-4cb3-beb3-299bdef297cb
[  134.916493] systemd[1]: Finished Ignition OSTree: Grow Root Filesystem.
[  134.996896] systemd[1]: Starting Ignition OSTree: Autosave XFS Rootfs Partition...

[Dasd_ignition_ostree.log](https://github.com/user-attachments/files/16203099/Dasd_ignition_ostree.log)

Attached boot log from zKVM-Fcos.

root@kvm:~# qemu-system-s390x -machine s390-ccw-virtio,accel=kvm -m 4096 -smp 2 -nographic -drive if=none,id=hda,file=/var/home/core/rhcos.qcow2,auto-read-only=off,cache=unsafe -device virtio-blk,iommu_platform=on,drive=hda -netdev user,id=eth,hostfwd=tcp::2222-:22 -device virtio-net-ccw,iommu_platform=on,netdev=eth -device vfio-ap,sysfsdev=/sys/devices/vfio_ap/matrix/68cd2d83-3eef-4e45-b22c-534f90b16cb9

Qemu
Qemu_qcow_ignition_ostree.log

travier

Not tested but LGTM. Thanks for cleaning up the luksdump output parsing.

madhu-pillai force-pushed the test_fcos_cex branch from 174381b to 03398df Compare April 29, 2024 04:14

madhu-pillai changed the title ~~overlay.d/05core: skip cex luks encrypted dasd from growfs~~ overlay.d/05core: add cex encrypted dasd in growfs Apr 29, 2024

madhu-pillai force-pushed the test_fcos_cex branch from 03398df to 6cc2836 Compare April 29, 2024 05:30

madhu-pillai force-pushed the test_fcos_cex branch from 6cc2836 to 7a753f0 Compare May 8, 2024 12:32

jlebon mentioned this pull request May 10, 2024

add S390x Cex base disk encryption coreos/ignition#1820

Merged

jlebon force-pushed the test_fcos_cex branch from 7a753f0 to 4bcebfb Compare May 20, 2024 13:17

jlebon changed the title ~~overlay.d/05core: add cex encrypted dasd in growfs~~ overlay/growfs: support CEX-encrypted LUKS volumes May 20, 2024

jlebon force-pushed the test_fcos_cex branch from 4bcebfb to 80c4665 Compare May 20, 2024 13:18

jlebon mentioned this pull request Jul 12, 2024

kola: add IBM CEX device test for the s390x build coreos/coreos-assembler#3828

Merged

travier previously approved these changes Jul 12, 2024

View reviewed changes

madhu-pillai and others added 3 commits July 12, 2024 11:52

overlay/growfs: support CEX-encrypted LUKS volumes

0498e2e

Support for CEX LUKS volumes was added in Ignition as part of coreos/ignition#1693. Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>

overlay/growfs: skip growpart on DASD disks

e6a6da6

If the partition is on a DASD disk, then don't run growpart since it doesn't know how to handle it and it's not needed (coreos-installer already sizes it to its maximum).

overlay/growfs: use luksDump JSON output for analysis

068d125

It's cleaner and less prone to false positives.

jlebon dismissed travier’s stale review via 068d125 July 12, 2024 15:53

jlebon force-pushed the test_fcos_cex branch from ad9a077 to 068d125 Compare July 12, 2024 15:53

travier approved these changes Jul 16, 2024

View reviewed changes

jlebon merged commit 5066197 into coreos:testing-devel Jul 16, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

overlay/growfs: support CEX-encrypted LUKS volumes #2986

overlay/growfs: support CEX-encrypted LUKS volumes #2986

madhu-pillai commented Apr 25, 2024 •

edited by jlebon

Loading

jlebon commented Apr 25, 2024

madhu-pillai commented Apr 26, 2024

madhu-pillai commented Apr 26, 2024

jlebon commented May 20, 2024

madhu-pillai commented May 21, 2024

madhu-pillai commented May 21, 2024

jlebon commented May 21, 2024

madhu-pillai commented May 22, 2024

jlebon commented May 22, 2024

travier left a comment

jlebon commented Jul 12, 2024

madhu-pillai commented Jul 12, 2024

madhu-pillai commented Jul 13, 2024 •

edited

Loading

travier left a comment •

edited

Loading

overlay/growfs: support CEX-encrypted LUKS volumes #2986

overlay/growfs: support CEX-encrypted LUKS volumes #2986

Conversation

madhu-pillai commented Apr 25, 2024 • edited by jlebon Loading

jlebon commented Apr 25, 2024

madhu-pillai commented Apr 26, 2024

madhu-pillai commented Apr 26, 2024

jlebon commented May 20, 2024

madhu-pillai commented May 21, 2024

madhu-pillai commented May 21, 2024

jlebon commented May 21, 2024

madhu-pillai commented May 22, 2024

jlebon commented May 22, 2024

travier left a comment

Choose a reason for hiding this comment

jlebon commented Jul 12, 2024

madhu-pillai commented Jul 12, 2024

madhu-pillai commented Jul 13, 2024 • edited Loading

travier left a comment • edited Loading

Choose a reason for hiding this comment

madhu-pillai commented Apr 25, 2024 •

edited by jlebon

Loading

madhu-pillai commented Jul 13, 2024 •

edited

Loading

travier left a comment •

edited

Loading