-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci & tests: Use registry.fedoraproject.org for Fedora container images #2988
base: testing-devel
Are you sure you want to change the base?
Conversation
The plan is to keep using the registry.fedoraproject.org name but redirect it to quay.io. Reverts: coreos#2623 See: https://pagure.io/fedora-infrastructure/issue/11543
Sorry - the above isn't that obvious. I'm referring to the |
Thanks! I'll add the 39->40 change to this PR. |
Those were missed in coreos#2981. Fixes: coreos#2981
Ah, sorry - I pushed the change before seeing your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks like I pushed it right after :) |
The only concern I have with this "redirect" plan is that it now makes our image pulls dependent on both registry.fedoraproject.org and Quay.io working, instead of just the latter. For that reason alone, I'd vote to just keep using Quay.io. ISTM like the main goal of the redirect approach is to not break existing docs/code, which is not a concern here since we've already done the work to move them over. Commented in https://pagure.io/fedora-infrastructure/issue/11543#comment-907073. |
It's also weird because we push directly to quay for our FCOS images. Inconsistency isn't great. |
Let's do #2990 first and then we'll see for this one. |
The plan is to keep using the registry.fedoraproject.org name but redirect it to quay.io.
Reverts: #2623
See: https://pagure.io/fedora-infrastructure/issue/11543