Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: dnf5 is now default in rawhide; stop symlinking dnf #2997

Merged
merged 1 commit into from
May 13, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 10, 2024

The postprocess bomb here went off this morning, which means we can simplify this by a lot!

dustymabe
dustymabe previously approved these changes May 10, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- |
#!/usr/bin/bash
set -euo pipefail
if command -v dnf; then
Copy link
Member

@dustymabe dustymabe May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way this test is constructed it looks like all it was doing was checking to see if the dnf5 package provides /usr/bin/dnf and then warning us.

It looks like CI is still pulling in a dnf that still requires python. Maybe the old dnf package is still there, but dnf5 now provides /usr/bin/dnf too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like it.

[root@1710845a3e2e /]# dnf repoquery dnf dnf5
Updating and loading repositories:
Repositories loaded.
dnf-0:4.20.0-1.fc41.noarch
dnf5-0:5.2.1.0-1.fc41.i686
dnf5-0:5.2.1.0-1.fc41.x86_64

Updated to still request dnf5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll know now when we need to make a change here because presumably the dnf5 package will no longer exist? of maybe dnf5 will be a virtual provides from the dnf package once it gets replaced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plan is for dnf5 to obsolete dnf so what we have here should keep working, but yeah ideally eventually we can just say dnf. I'm not sure if the obsolete bit would be enough for that though.

The postprocess bomb here went off this morning, which means we can
simplify this by a lot!
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 1f45497 into coreos:testing-devel May 13, 2024
3 checks passed
@jlebon jlebon deleted the pr/dnf5-default branch May 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants