overlay.d/05core: assume metadata_csum_seed in ignition-ostree-firstboot-uuid #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "CoreOS" to the beginning of coreos-unique-boot.service
- Add "Ignition" to the coreos-ignition-unique-boot.service
- This is an attempt to distinguish it from the other
- Change `boot` to Boot since that difference wasn't significant
…oot-uuid We always set the metadata_csum_seed option on the ext4 filesystems now so let's remove the conditional logic from the code.
dustymabe
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
May 21, 2024
Here we just unconditionally set it because otherwise changing the filesystem while it is mounted doesn't work and we get errors like this during startup: ``` [ 4.155947] ignition-ostree-firstboot-uuid[918]: /dev/disk/by-label/boot is in use. ``` Anyways, we are going to delete the fallback code there anyway coreos/fedora-coreos-config#3008 so it's required to be set so let's set it here and then we can drop this once RHEL has caught up.
dustymabe
added a commit
to coreos/coreos-assembler
that referenced
this pull request
May 22, 2024
Here we just unconditionally set it because otherwise changing the filesystem while it is mounted doesn't work and we get errors like this during startup: ``` [ 4.155947] ignition-ostree-firstboot-uuid[918]: /dev/disk/by-label/boot is in use. ``` Anyways, we are going to delete the fallback code there anyway coreos/fedora-coreos-config#3008 so it's required to be set so let's set it here and then we can drop this once RHEL has caught up.
jlebon
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always set the metadata_csum_seed option on the ext4 filesystems
now so let's remove the conditional logic from the code.
Also have a 2nd commit in here to tweak descriptions of some unit files.