overlays: drop coreos-multipath-trigger.service
#3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This service was needed in the past to make multipath + LUKS work well. The underlying bug seems to have been fixed now as I can no longer reproduce it in Fedora or RHEL 9.4. Conveniently, this also works around a bug in which that service would sometimes hang because of a bug[[1]] in systemd which is still outstanding in RHEL 9. Drop it. We don't have any tests for this yet. Multipath + LUKS currently doesn't work but should be fixed soon[[2]]. A test will be added as part of that work. [1]: systemd/systemd#29863 [2]: coreos/fedora-coreos-tracker#1728 Fixes: https://issues.redhat.com/browse/OCPBUGS-29325
For this reason, we should backport this to at least 4.14. I haven't checked if the bug that motivated this service is still in 9.2 or not, but it doesn't matter because we in effect don't support multipath + LUKS anyway since we've regressed a long time ago (all active streams are affected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service was needed in the past to make multipath + LUKS work well. The underlying bug seems to have been fixed now as I can no longer reproduce it in Fedora or RHEL 9.4. Conveniently, this also works around a bug in which that service would sometimes hang because of a bug[1] in systemd which is still outstanding in RHEL 9.
Drop it.
We don't have any tests for this yet. Multipath + LUKS currently doesn't work but should be fixed soon[2]. A test will be added as part of that work.
Fixes: https://issues.redhat.com/browse/OCPBUGS-29325