kola/kernel-replace: Add OS_ID recogntion #3048
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
requested changes
Jul 2, 2024
| ## # This test only runs on FCOS due to a problem with skopeo copy on | ||
| ## # RHCOS. See: https://github.com/containers/skopeo/issues/1846 | ||
| ## distros: fcos | ||
| ## distros: "fcos rhcos scos" |
There was a problem hiding this comment.
just omit the tag would work from what i understand ?
| image=oci:$image_dir | ||
| image_pull=ostree-unverified-image:$image | ||
| tmp_imagedir=/var/tmp/fcos-tmp | ||
| tmp_imagedir=/var/tmp/$OS_ID-tmp |
There was a problem hiding this comment.
shellcheck will complain :)
jlebon
reviewed
Jul 4, 2024
| @@ -43,10 +41,13 @@ set -euxo pipefail | |||
| cd $(mktemp -d) | |||
|
|
|||
| # TODO: It'd be much better to test this via a registry | |||
| image_dir=/var/tmp/fcos | |||
|
|
|||
| OS_ID=$(grep '^ID=' /etc/os-release | cut -d "=" -f2) | |||
There was a problem hiding this comment.
How we name the image dir and built images is purely cosmetic. Instead of this, we could s/fcos/coreos/ instead to make it more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were instances where kola/switch-kernel test would fail.
It was recommended to remove it (PR) and generalize this test, so that it can work with FCOS, RHCOS and SCOS.