Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] tree: promote changes from testing-devel at a8c84a3e055500ce8119535240f17e9e78fb1f4e #358

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sinnykumari
Copy link
Contributor

No description provided.

@jlebon
Copy link
Member

jlebon commented Apr 20, 2020

CI is printing:

+ jq .pkgdiff /srv/fcos/builds/latest/x86_64/meta.json
[
  [
    "curl-minimal",
    0,
    {
      "NewPackage": [
        "curl-minimal",
        "7.69.1-1.fc32",
        "x86_64"
      ]
    }
  ],
  [
    "libcurl-minimal",
    0,
    {
      "NewPackage": [
        "libcurl-minimal",
        "7.69.1-1.fc32",
        "x86_64"
      ]
    }
  ],

which is due to coreos/fedora-coreos-tracker#454. I've just untagged f32 curl from the pool again for now, though I'm also working on getting coreos/rpm-ostree#1858 and coreos/coreos-assembler#1370 into cosa.

@dustymabe
Copy link
Member

though I'm also working on getting coreos/rpm-ostree#1858 and coreos/coreos-assembler#1370 into cosa.

we should wait on ^^ for this week's spin, right @jlebon ?

@sinnykumari
Copy link
Contributor Author

latest ci run doesn't include curl-minimal and libcurl-minimal packages

@jlebon
Copy link
Member

jlebon commented Apr 20, 2020

we should wait on ^^ for this week's spin, right @jlebon ?

I think it'd be good, yeah. This is almost ready actually; just needs a final review and /lgtm on coreos/coreos-assembler#1370 and then the patches mentioned in coreos/coreos-assembler#1370 (comment).

If something doesn't work quite right yet with the new code, we can revert back to just making sure curl f32 stays tagged out and sanity-checking the diffs.

@jlebon
Copy link
Member

jlebon commented Apr 20, 2020

I restarted CI again now that coreos/coreos-assembler#1370 and coreos/coreos-ci-lib#23 are in, but looks like we need to blow the Quay.io cache: coreos/coreos-assembler#1377

@jlebon
Copy link
Member

jlebon commented Apr 20, 2020

All green now, and diff looks good! In retrospect, I should've left the curl f32 package in the pool as a test. However, the previous CI run (without --strict) also had libbrotli from f32 added, and that's indeed gone too now.

There's another lockfile bump in #360 I think we wanted to get in before doing this release. And then I think we're good to go!

@dustymabe
Copy link
Member

#360 merged and doing a testing-devel pipeline run now to confirm everything looks good

@dustymabe dustymabe changed the title tree: promote changes from testing-devel at 49de0c72b082c3e3b6bb1e9015691246a2fd8727 [testing] tree: promote changes from testing-devel at 49de0c72b082c3e3b6bb1e9015691246a2fd8727 Apr 21, 2020
@sinnykumari sinnykumari changed the title [testing] tree: promote changes from testing-devel at 49de0c72b082c3e3b6bb1e9015691246a2fd8727 [testing] tree: promote changes from testing-devel at a8c84a3e055500ce8119535240f17e9e78fb1f4e Apr 21, 2020
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinnykumari sinnykumari merged commit 5122f0d into coreos:testing Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants