overlay/live-generator: Add requires/after for rootfs on ISO #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Testing this locally) |
|
seems reasonable. This does appear to be a race condition so it might be worth trying to loop to see how consistent it is before and after this change. For example I just ran my install again and it booted fine so I'm 1/2 on hitting the issue. Hopefully after this change we don't hit it at all. |
We are seeing RHCOS ISO bootup fail sometimes, I think we're racing with some udev probe transiently inspecting the CD. I believe that by adding this `After=`, we're serializing on udev probing being complete for that device. Plus, it's just best practice anyways.
|
OK tested and I'm so far 8/8 on boots. |
dustymabe
approved these changes
May 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing RHCOS ISO bootup fail sometimes, I think we're racing
with some udev probe transiently inspecting the CD.
I believe that by adding this
After=, we're serializing onudev probing being complete for that device. Plus, it's
just best practice anyways.