Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-devel] overrides: fast-track systemd 245.8-2 #630

Merged
merged 1 commit into from
Sep 23, 2020
Merged

[testing-devel] overrides: fast-track systemd 245.8-2 #630

merged 1 commit into from
Sep 23, 2020

Conversation

sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented Sep 22, 2020

This version has a fix for the Ignition issue (coreos/ignition#1064)

@sohankunkerkar sohankunkerkar changed the title overrides: fast-track systemd 245.8-2 [testing]overrides: fast-track systemd 245.8-2 Sep 22, 2020
@sohankunkerkar sohankunkerkar changed the title [testing]overrides: fast-track systemd 245.8-2 [testing] overrides: fast-track systemd 245.8-2 Sep 22, 2020
@sohankunkerkar
Copy link
Member Author

Confirmed that the Ignition issue got resolved by this version.

[core@localhost ~]$ systemctl --version
systemd 245 (v245.8-2.fc32)
+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 default-hierarchy=unified

[core@localhost ~]$ systemctl status echo@foo.service
● echo@foo.service - echo service template
     Loaded: loaded (/etc/systemd/system/echo@.service; enabled; vendor preset: enabled)
     Active: inactive (dead) since Tue 2020-09-22 20:28:47 UTC; 19s ago
TriggeredBy: ● echo@foo.timer
    Process: 1073 ExecStart=/bin/echo foo (code=exited, status=0/SUCCESS)
   Main PID: 1073 (code=exited, status=0/SUCCESS)

Sep 22 20:28:47 localhost systemd[1]: Starting echo service template...
Sep 22 20:28:47 localhost echo[1073]: foo
Sep 22 20:28:47 localhost systemd[1]: echo@foo.service: Succeeded.
Sep 22 20:28:47 localhost systemd[1]: Finished echo service template.
Sep 22 20:29:06 localhost systemd[1]: Starting echo service template...
Sep 22 20:29:06 localhost echo[1076]: foo
Sep 22 20:29:06 localhost systemd[1]: echo@foo.service: Succeeded.
Sep 22 20:29:06 localhost systemd[1]: Finished echo service template.
[core@localhost ~]$ systemctl status echo@foo.timer
● echo@foo.timer - echo timer template
     Loaded: loaded (/etc/systemd/system/echo@.timer; enabled; vendor preset: enabled)
     Active: active (waiting) since Tue 2020-09-22 20:27:41 UTC; 1min 36s ago
    Trigger: Tue 2020-09-22 20:29:16 UTC; 1s ago
   Triggers: ● echo@foo.service

Ignition Config used:

{
  "ignition": {
    "config": {
      "replace": {
        "source": null,
        "verification": {}
      }
    },
    "security": {
      "tls": {}
    },
    "timeouts": {},
    "version": "3.0.0"
  },
  "passwd": {
    "users": [
      {
        "name": "core",
        "sshAuthorizedKeys": [
          "ssh-rsa AAAA--"
        ]
      }
    ]
  },
  "storage": {},
  "systemd": {
    "units": [
      {
        "enabled": true,
        "name": "echo@foo.service"
      },
      {
        "enabled": true,
        "name": "echo@foo.timer"
      },
      {
        "contents": "[Unit]\nDescription=echo service template\n[Service]\nType=oneshot\nExecStart=/bin/echo %i\n[Install]\nWantedBy=multi-user.target\n",
        "name": "echo@.service"
      },
      {
        "contents": "[Unit]\nDescription=echo timer template\n[Timer]\nOnUnitInactiveSec=10s\n[Install]\nWantedBy=timers.target",
        "name": "echo@.timer"
      }
    ]
  }
}

@jlebon jlebon changed the title [testing] overrides: fast-track systemd 245.8-2 [testing-devel] overrides: fast-track systemd 245.8-2 Sep 23, 2020
@jlebon
Copy link
Member

jlebon commented Sep 23, 2020

How important is this fix? We're about to cut another next and testing release, and could get this in for those. Though it's a bit last minute.

OTOH, looks like it's almost in stable and it's a minor release bump from 245.7 to 245.8, so meh... I'm cool with it.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though let's let someone else chime in as well.

This version has a fix for the Ignition issue (coreos/ignition#1064)
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sohankunkerkar sohankunkerkar merged commit 3ecf0ee into coreos:testing-devel Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants