Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kola/root-reprovision: bump the amount of RAM to 6G as 4G is not enough on ppc64le #658

Closed
wants to merge 1 commit into from

Conversation

jcajka
Copy link
Contributor

@jcajka jcajka commented Oct 2, 2020

Re-provision tests runs will fail(log in attachment), with something that seems as not enough memory on ppc64le. Increasing the memory size to the 6G enables the tests pass(obtained by trail and error). I assume that this is most probably caused by the image being roughly ~200M bigger than on the x86_64 and by usage of the 64k pages on the ppc64le.`
ppc64le-raid1.log

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wish there was a way to make it conditional on the architecture. 4G already meant a lot relative to my puny laptop. 6G is half my total memory.

Maybe what we want is a root-reprovision tag which kola knows to mean bumping the memory accordingly?

Anyway, we can get this in for now.

@cgwalters
Copy link
Member

I think if we added support for instance sizes coreos/coreos-assembler#1651 (comment) then we could scale those up by 20% or whatever for architectures with 64k pages.

@arithx
Copy link
Contributor

arithx commented Oct 2, 2020

Hmm, I wish there was a way to make it conditional on the architecture. 4G already meant a lot relative to my puny laptop. 6G is half my total memory.

Maybe what we want is a root-reprovision tag which kola knows to mean bumping the memory accordingly?

Anyway, we can get this in for now.

As a temporary workaround we could always do the hacky method of having architecture specific duplicated tests with different memory requirements.

@jcajka
Copy link
Contributor Author

jcajka commented Oct 5, 2020

@jlebon @cgwalters: I will look on that, it makes most sense. I think that we can even bump the minimal amount of memory on 64k arches to something like 8G, safely(it should be ppc64le only and those are usually pretty beefy, whatever VMs or whole hosts). What do you think? CC'ing @Prashanth684
From other side what is the minimal amount of memory that we target for the COS hosts? From my rather naive perceptive I would assume something in line with 8G+(with the use cases that we mention, maybe with exception of the aarch64 as there is still rather rare to see sbcs with more than 4G).
@jlebon: tbh I haven't been able to build COS from scratch locally(on x86_64) until like a week ago when I bought myself a new bigger disk for my laptop(podman's storage driver needs like ~50G of free space to build the container image, although the storage taken afterwards is way, way less...).

@jlebon
Copy link
Member

jlebon commented Oct 5, 2020

Cross-linking: #640 (comment)

Restamped this to trigger CI here.

@jcajka
Copy link
Contributor Author

jcajka commented Oct 6, 2020

Moved the solution in to the kola via coreos/coreos-assembler#1768

@jcajka jcajka closed this Oct 6, 2020
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants