-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/kola/root-reprovision: bump the amount of RAM to 6G as 4G is not enough on ppc64le #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wish there was a way to make it conditional on the architecture. 4G already meant a lot relative to my puny laptop. 6G is half my total memory.
Maybe what we want is a root-reprovision
tag which kola knows to mean bumping the memory accordingly?
Anyway, we can get this in for now.
I think if we added support for instance sizes coreos/coreos-assembler#1651 (comment) then we could scale those up by 20% or whatever for architectures with 64k pages. |
As a temporary workaround we could always do the hacky method of having architecture specific duplicated tests with different memory requirements. |
@jlebon @cgwalters: I will look on that, it makes most sense. I think that we can even bump the minimal amount of memory on 64k arches to something like 8G, safely(it should be ppc64le only and those are usually pretty beefy, whatever VMs or whole hosts). What do you think? CC'ing @Prashanth684 |
…t enough on ppc64le
3b1d5b4
to
dedba5a
Compare
Cross-linking: #640 (comment) Restamped this to trigger CI here. |
Moved the solution in to the kola via coreos/coreos-assembler#1768 |
fedora-coreos-config: bump to a1f89fa
Re-provision tests runs will fail(log in attachment), with something that seems as not enough memory on ppc64le. Increasing the memory size to the 6G enables the tests pass(obtained by trail and error). I assume that this is most probably caused by the image being roughly ~200M bigger than on the x86_64 and by usage of the 64k pages on the ppc64le.`
ppc64le-raid1.log