Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use the exttests container #677

Draft
wants to merge 1 commit into
base: testing-devel
Choose a base branch
from
+3 −1
Draft

ci: Use the exttests container #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .cci.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Documentation: https://github.com/coreos/coreos-ci/blob/master/README-upstream-ci.md

cosaPod {
// Use the exttests container here in CI to get extra coverage; xref
// https://github.com/coreos/coreos-assembler/pull/1745
cosaPod(image: "registry.svc.ci.openshift.org/coreos/cosa-exttests:latest") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a strong preference for having CI keep using the canonical cosa image from quay.io for all the main steps. It's what devs use locally. We've also had multiple encounters with OpenShift CI having stale versions of cosa or rebuilds of layered images like this not triggering. It's a major pain to debug.

How about instead we add sugar to coreos-ci-lib to have the exttest container be added to the pod and then for the kola run, it knows to use the exttest container just for the installed tests? (I.e. using container("exttests") { ... }).

Hmm, or maybe it is indeed easier to just fold this into cosa for now until we do something fancier as discussed in coreos/coreos-assembler#1745.

checkoutToDir(scm, 'config')

shwrap("cd config && ci/validate")
Expand Down