Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Drop ostree-grub2 from ppc64le bootloader #682

Open
wants to merge 1 commit into
base: testing-devel
Choose a base branch
from

Conversation

cgwalters
Copy link
Member

We temporarily re-added this in
1f399c3
But we've long since dropped Anaconda on all architectures.

In particular this bit applies for ppc64le:
https://github.com/coreos/coreos-assembler/blob/a73ad29717e9f16e321b9c0b47cb7eeda31ba330/src/create_disk.sh#L314

Note though this is only true for FCOS; for RHCOS
we still ship ostree-grub2 because we need to handle
4.1/4.2 bootimages sadly.

We temporarily re-added this in
1f399c3
But we've long since dropped Anaconda on all architectures.

In particular this bit applies for ppc64le:
https://github.com/coreos/coreos-assembler/blob/a73ad29717e9f16e321b9c0b47cb7eeda31ba330/src/create_disk.sh#L314

Note though this is only true for FCOS; for RHCOS
we still ship ostree-grub2 because we need to handle
4.1/4.2 bootimages sadly.
@cgwalters
Copy link
Member Author

Immediate motivation for this is I was looking at coreos/bootupd#50

@cgwalters
Copy link
Member Author

Pinged @ravanelli to test this. (That said I may try to look again at multi-arch devenvs)

Copy link
Member

@ravanelli ravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For FCOS the build went ok as the testiso tests:
kola testiso -S --scenarios pxe-install,iso-install,iso-offline-install

The basic tests and basic-qemu-scenarios are failing due an issue with the config.ign:

sh-5.0# cosa kola run --basic-qemu-scenarios
⚠️ Skipping kola test pattern "fcos.internet":
⚠️ coreos/coreos-assembler#1478
⚠️ Skipping kola test pattern "podman.workflow":
⚠️ coreos/coreos-assembler#1478
kola --denylist-test fcos.internet --denylist-test podman.workflow --output-dir tmp/kola run basic
Error: Parsing config.ign: unsupported config version
2020-10-15T23:45:26Z cli: Parsing config.ign: unsupported config version
Traceback (most recent call last):

It doesn't look to me an issue with this change.

@cgwalters
Copy link
Member Author

Thanks for testing!

2020-10-15T23:45:26Z cli: Parsing config.ign: unsupported config version

Right hmm, which coreos-assembler are you using? For testing FCOS (and current RHCOS) you want the latest from https://quay.io/repository/coreos-assembler/coreos-assembler

@ravanelli
Copy link
Member

@cgwalters I built it directly from the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants