Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignition-ostree-rootfs: use our own tmpfs with size=80% #685

Merged
merged 3 commits into from
Oct 14, 2020
Merged

ignition-ostree-rootfs: use our own tmpfs with size=80% #685

merged 3 commits into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. ignition-ostree-rootfs: drop unnecessary EnvironmentFile= 

    We don't need access to the platform ID, so just drop it.
    @jlebon
    jlebon committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    e337727 View commit details
    Browse the repository at this point in the history

  2. ignition-ostree-rootfs: avoid unnecessary cd 

    We can just pass the path to `find` directly.

Prep for next patch.
    @jlebon
    jlebon committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    4e6c4b4 View commit details
    Browse the repository at this point in the history

  3. ignition-ostree-rootfs: use our own tmpfs with size=80% 

    In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=80%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
    @jlebon
    jlebon committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1c9a493 View commit details
    Browse the repository at this point in the history