Move buildroot image here #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs some fleshing out around how this solves the kolet case, though let's keep the discussions about that in coreos/coreos-assembler#1863. |
cgwalters
approved these changes
Mar 25, 2021
cgwalters
reviewed
Mar 25, 2021
|
OK, rebased and ready to go! Tested locally with |
When using cosa to build OSes, we've been pretty good at shielding ourselves from versioning differences between source and target environments (for example, RHCOS is built by Fedora packages). But when it comes to building things meant to run *in* that OS, we really should match the buildroot of the target. Right now, many of our projects use the buildroot cosa container to build their projects in CI. But this doesn't necessarily match the buildroot of the rest of the OS. Since the buildroot to use is defined here (specifically via the `releasever` key), let's move the concept of a "buildroot image" from cosa to here. Specifically, we want a container image with all the deps to the components we mostly hack on for use by both CI and local developers. This can then be used by CoreOS CI for building upstream projects, as well as by cosa itself for building kolet. See also: coreos/coreos-assembler#1863
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 25, 2021
This was moved to the fedora-coreos-config repo in coreos/fedora-coreos-config#740
cgwalters
reviewed
Mar 25, 2021
| @@ -0,0 +1,39 @@ | |||
| # This is a list of basic buildrequires; it'd be a bit better to | |||
There was a problem hiding this comment.
Just to xref: coreos/rpm-ostree#2326 (comment)
|
That said there is a somewhat profound thing going on here in not deriving from coreos-assembler because some of our CI may actually rely on tools in cosa but not in this buildroot. But...let's try it out! |
cgwalters
approved these changes
Mar 25, 2021
(Which...is going to lead to the question of whether we should in some cases ship some parts of cosa as an RPM) |
|
Skipping CI since it's separate files which don't affect the compose at all. |
jlebon
added a commit
to jlebon/coreos-ci-lib
that referenced
this pull request
Mar 25, 2021
We're moving away from a buildroot image based on cosa to one based on FCOS: coreos/fedora-coreos-config#740 Correspondingly, add a new `buildPod` as a thin sugar for selecting that image.
cgwalters
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 25, 2021
This was moved to the fedora-coreos-config repo in coreos/fedora-coreos-config#740
cgwalters
added a commit
to cgwalters/release
that referenced
this pull request
Mar 25, 2021
See coreos/fedora-coreos-config#740 which we now need to use in our Prow jobs too.
jlebon
added a commit
to jlebon/ssh-key-dir
that referenced
this pull request
Mar 29, 2021
Similar to coreos/ignition#1182 as a result of coreos/fedora-coreos-config#740.
jlebon
added a commit
to jlebon/ssh-key-dir
that referenced
this pull request
Mar 29, 2021
Similar to coreos/ignition#1182 as a result of coreos/fedora-coreos-config#740. As a bonus, we now get a clear separate stage for building. Add a stage for running unit tests, but keep it commented out for now and we'll circle back to it when it's cleaner to do once we have: coreos/fedora-coreos-config#917 GitHub Actions covers unit tests anyway.
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
extensions: Remove references to qemu-kiwi and advanced-virt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cosa to build OSes, we've been pretty good at shielding
ourselves from versioning differences between source and target
environments (for example, RHCOS is built by Fedora packages). But when
it comes to building things meant to run in that OS, we really should
match the buildroot of the target.
Right now, many of our projects use the buildroot cosa container to
build their projects in CI. But this doesn't necessarily match the
buildroot of the rest of the OS.
Since the buildroot to use is defined here (specifically via the
releaseverkey), let's move the concept of a "buildroot image" fromcosa to here. Specifically, we want a container image with all the deps
to the components we mostly hack on for use by both CI and local
developers.
This can then be used by CoreOS CI for building upstream projects, as
well as by cosa itself for building kolet.
See also: coreos/coreos-assembler#1863