Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/metal: Briefly discuss heterogenous hardware #219

Merged
merged 1 commit into from
Dec 15, 2020
Merged

docs/metal: Briefly discuss heterogenous hardware #219

merged 1 commit into from
Dec 15, 2020

Conversation

cgwalters
Copy link
Member

Has come up a few times, see also coreos/ignition#1126

jlebon
jlebon reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, WDYT about making this a subsection or NOTE that's under the "Prerequisite" section instead at the top of the page? That's where we talk about producing Ignition configs.

modules/ROOT/pages/bare-metal.adoc Outdated Show resolved Hide resolved
@cgwalters cgwalters changed the title docs/metal: Briefly discuss hetrogenous hardware docs/metal: Briefly discuss heterogenous hardware Dec 15, 2020
@cgwalters
Copy link
Member Author

OK, moved it up.

bgilbert
bgilbert reviewed Dec 15, 2020
View reviewed changes
modules/ROOT/pages/bare-metal.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/bare-metal.adoc Outdated Show resolved Hide resolved
@cgwalters
Copy link
Member Author

OK addressed those comments.

bgilbert
bgilbert approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miabbott
miabbott approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 4ec32ab into coreos:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@bgilbert bgilbert bgilbert approved these changes

@miabbott miabbott miabbott approved these changes

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cgwalters @bgilbert @miabbott @jlebon @travier