jobs/fix-build: support verifying signuates #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, `cosa sign` verifies that the signatures from Robosignatory are valid and then makes them public. We need to retain this check when using `fix-build` for safety (and also because we need the sigs public). Just make this so that if `SKIP_SIGNING` is on (i.e. we know the builds were eventually signed), then pass `--verify-only` to `cosa sign` which will skip re-requesting signing. Patch best viewed with whitespace ignored.
|
Requires: coreos/coreos-assembler#3821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally,
cosa signverifies that the signatures from Robosignatory are valid and then makes them public. We need to retain this check when usingfix-buildfor safety (and also because we need the sigs public).Just make this so that if
SKIP_SIGNINGis on (i.e. we know the builds were eventually signed), then pass--verify-onlytocosa signwhich will skip re-requesting signing.Patch best viewed with whitespace ignored.