Add GCP image uploads to the pipeline #219
Conversation
|
Currently WIP, but this should be close. Doing some testing. Will add kola tests in a followup. |
HACKING.md
Outdated
| create a credentials config as a secret within OpenShift. | ||
|
|
||
| First grab a json file that represents the credentials for your service account | ||
| from GCP. Then create the secret in OpenShift: |
There was a problem hiding this comment.
Can we put more details here on where to get the JSON file from/what format it is?
| optional: true | ||
| # This secret is used for running GCP kola tests | ||
| - name: gcp-image-upload-config | ||
| - name: gcp-kola-tests-config |
manifests/pod.yaml
Outdated
| - name: GCP_KOLA_TESTS_CONFIG | ||
| value: /.gcp-kola-tests-config | ||
| - name: gcp-image-upload-config | ||
| - name: gcp-kola-tests-config |
manifests/pod.yaml
Outdated
| - name: GCP_IMAGE_UPLOAD_CONFIG | ||
| value: /.gcp-image-upload-config | ||
| - name: GCP_KOLA_TESTS_CONFIG | ||
| value: /.gcp-kola-tests-config |
There was a problem hiding this comment.
Yeah... we should really look at constraining each container run to the minimal set of credentials it needs. E.g. no reason the AWS kola test needs GCP creds mounted in.
There was a problem hiding this comment.
I assume you mean something for us to do in the future?
dustymabe
force-pushed
the
dusty-add-gcp
branch
2 times, most recently
from
5a66e2e
to
347fdd0
Compare
|
pushed up a few small fixes for this. Now seems to be working in the pipeline! |
|
depends on coreos/coreos-assembler#1319 |
|
ok added a commit that removes the need to specify the project in various places. One final review before merge? |
We seem to be in a transition from GCE to GCP terminology. Let's update it here too.
|
coreos/coreos-assembler#1319 merged. |
No description provided.