Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: add bump-lockfile #229

Merged
merged 1 commit into from
May 5, 2020
Merged

jobs: add bump-lockfile #229

merged 1 commit into from
May 5, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 1, 2020

This job will implement lockfile bumping for testing-devel and
next-devel: coreos/fedora-coreos-tracker#293.

The original plan for this functionality was to have it in config-bot:
coreos/fedora-coreos-releng-automation#48

But in the end, I think it's more natural to have it as a Jenkins job
given that it does a lot of the same things as the pipeline/upstream CI
jobs. So that way it looks and feels just like another job that runs
cosa, and we get kola artifacts, we can re-use the shared library,
it's easily inspectable, we can hook it to Slack, etc...

@jlebon
Copy link
Member Author

jlebon commented May 1, 2020

Requires: #228

Marking as draft, since I haven't tested this at all for now!

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - exciting things to come!

@jlebon jlebon force-pushed the pr/lockfile-bumper branch 5 times, most recently from 455039b to b6cb4e7 Compare May 4, 2020 20:47
@jlebon jlebon marked this pull request as ready for review May 4, 2020 20:47
This job will implement lockfile bumping for testing-devel and
next-devel: coreos/fedora-coreos-tracker#293.

The original plan for this functionality was to have it in config-bot:
coreos/fedora-coreos-releng-automation#48

But in the end, I think it's more natural to have it as a Jenkins job
given that it does a lot of the same things as the pipeline/upstream CI
jobs. So that way it looks and feels just like another job that runs
cosa, and we get kola artifacts, we can re-use the shared library,
it's easily inspectable, we can hook it to Slack, etc...
@jlebon
Copy link
Member Author

jlebon commented May 4, 2020

OK, this is tested working now! I hit a subtle issue with lockfiles and shim-x64 which I need to follow-up with, though this PR is hacking around that for now.

@dustymabe Want to take a final look before we merge this?

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants