Add pipeline to test GCP images #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Jenkinsfile.kola.gcp file that will allow us to run tests against GCP images just like we do for AWS images.
|
Note that this PR doesn't enable the test to be called by the default pipeline yet. I'll need to debug and make sure everything works first. Since this is a side pipeline I'd like to do it in prod since I currently don't have a secondary pipeline environment to run this in. The proposal is that we merge this and then I run it a few times in prod and fix any bugs before we enable it being called from the main Jenkinsfile. |
jlebon
approved these changes
May 13, 2020
There was a problem hiding this comment.
We should probably add all new jobs in the new style from now on. Though I don't blame you for just copy/pasting the AWS one and tweaking a few knobs. :) (A further cleanup actually would be to dedupe those two and just run the tests in parallel.)
Anyway, this LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Jenkinsfile.kola.gcp file that will allow us to run tests
against GCP images just like we do for AWS images.