Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for GCP image build/release workflow #237

Merged
merged 1 commit into from
May 19, 2020

Conversation

dustymabe
Copy link
Member

In our build/release workflow for GCP we will build and upload/create
a GCP image in the build pipeline. In the build pipeline we will
deprecate the image because we haven't decided to release it yet.
In the release pipeline we will undeprecate the image and deprecate
all other images in that image family using the ore gcloud promote-image
command.

Also attach the image to a license upon creation.

@dustymabe
Copy link
Member Author

depends on coreos/coreos-assembler#1456

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In our build/release workflow for GCP we will build and upload/create
a GCP image in the build pipeline. In the build pipeline we will
deprecate the image because we haven't decided to release it yet.
In the release pipeline we will undeprecate the image and deprecate
all other images in that image family using the ore gcloud promote-image
command.

Also attach the image to a license upon creation.
@dustymabe
Copy link
Member Author

Thanks @bgilbert . I tested this pretty well tonight in a separate pipeline (found one missing } and some whitespace changes I needed to make). I'm going to merge this so we can use the code in the releases we do tomorrow.

@dustymabe dustymabe marked this pull request as ready for review May 19, 2020 06:08
@dustymabe dustymabe merged commit ad2579f into coreos:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants