jobs/build: add support for reading variant from stream/pipeline config #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not mention any specific variant name in this PR. Something like "Add support for reading variant from the stream/pipecfg config" |
travier
approved these changes
Dec 13, 2022
marmijo
changed the title
|
Can you add documentation for the new knob in |
I added a note in the docs about this in the most recent push |
jlebon
reviewed
Dec 13, 2022
travier
approved these changes
Dec 13, 2022
jlebon
reviewed
Dec 13, 2022
jobs/cloud-replicate.Jenkinsfile
Outdated
| @@ -35,6 +35,8 @@ properties([ | |||
|
|
|||
| def build_description = "[${params.STREAM}]" | |||
|
|
|||
| def stream_info = pipecfg.streams[params.STREAM] | |||
There was a problem hiding this comment.
This is already defined lower down.
jobs/kola-openstack.Jenkinsfile
Outdated
| @@ -41,6 +41,8 @@ properties([ | |||
|
|
|||
| currentBuild.description = "[${params.STREAM}][${params.ARCH}] - ${params.VERSION}" | |||
|
|
|||
| def variant = stream_info.variant ? "--variant ${stream_info.variant}" : "" | |||
There was a problem hiding this comment.
I suppose you meant to define stream_info here?
jobs/release.Jenkinsfile
Outdated
| @@ -42,6 +42,8 @@ properties([ | |||
|
|
|||
| def build_description = "[${params.STREAM}]" | |||
|
|
|||
| def stream_info = pipecfg.streams[params.STREAM] | |||
There was a problem hiding this comment.
This is already defined lower down.
jlebon
approved these changes
Dec 14, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in
build.jenkinsfileandbuild-arch.jenkinsfilefor reading variant information from the pipeline config/stream and passing it intocosa init.xref: https://gitlab.cee.redhat.com/coreos/rhcos-devel-pipecfg/-/merge_requests/3 & https://gitlab.cee.redhat.com/coreos/rhcos-art-pipecfg/-/merge_requests/9
See COS-1925