Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secrets definition in release job #897

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

ravanelli
Copy link
Member

  • If a secret doesn't exist it will fail to be mounted, as volume Mounts.
  • For now let's not pass it as argument to cosaPod, if we don't need the secret

 - If a secret doesn't exist it will fail to be mounted, as
volume Mounts.
 - For now let's not pass it as argument to cosaPod, if we
don't need the secret

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants