build-podman-os: Add extra-kargs #975
Conversation
ravanelli
commented
Apr 8, 2024
ravanelli
commented
- Reflect changes from osbuild: various cleanups; fix support for extra-kargs coreos-assembler#3770, adding the extra-kargs configuration from image-base.yaml
ravanelli
force-pushed
the
pr/kernel_extra
branch
from
475285f
to
3821435
Compare
jobs/build-podman-os.Jenkinsfile
Outdated
| extra_kargs = shwrapCapture(""" | ||
| python3 -c 'import sys, yaml; data = yaml.safe_load(sys.stdin)["extra-kargs"][0]; \ | ||
| print(data)' < src/config/image-base.yaml | ||
| """) |
There was a problem hiding this comment.
honestly I'm not sure what the best approach is right here.
eventually I think we want this whole process decoupled from Fedora CoreOS and this is probably the opposite direction.
I think we should either hardcode the value here (mitigations=auto,nosmt) or possibly we decide that mitigations=auto,nosmt doesn't make sense for podman machine (i.e. it's running on someone's laptop, not shared hardware) and we omit adding that kernel argument at all here.
There was a problem hiding this comment.
Chatted with Dusty about this OOB.
In the general case, I think ideally running osbuild does pick up the values from the embedded image.json (or maybe eventually the same config files as bootc).
Specifically for this case, yeah I think probably we don't need to pick up this karg here (and in the future, this would be e.g. overriding it during the container build phase instead).
There was a problem hiding this comment.
ideally running osbuild does pick up the values from the embedded image.json (or maybe eventually the same config files as bootc).
For the latter this will happen as part of osbuild/bootc-image-builder#18 which will unblock using https://containers.github.io/bootc/man-md/bootc-install-config.html which can be embedded in the container image.
So once FCOS derives from a shared base image we can just add a little bootc install drop-in which will configure that install-time karg in a container-native way.
- Reflect changes from coreos/coreos-assembler#3770 - Add the extra-kargs to the configuration Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
force-pushed
the
pr/kernel_extra
branch
from
3821435
to
dec757c
Compare
