release-notes: fix syntax error #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 61a9d2b ("release-notes: updates for the 20240703 releases"). Desperately need coreos#628.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Jul 4, 2024
This unassuming job is actually critical to the release pipeline flow. We have checkbox items in the release checklist to make sure that it ran correctly, but for other things (e.g. reverting a rollout, or adding release notes), there's zero visibility into whether the sync actually happened unless one goes to check the job. Let's just always send a Slack notification if the job fails. Prompted by noticing that it failed recently because of coreos/fedora-coreos-streams#924 only by pure chance (I was looking at the job for another reason). Patch best viewed with whitespace ignored.
gursewak1997
approved these changes
Jul 4, 2024
jlebon
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Jul 5, 2024
This unassuming job is actually critical to the release pipeline flow. We have checkbox items in the release checklist to make sure that it ran correctly, but for other things (e.g. reverting a rollout, or adding release notes), there's zero visibility into whether the sync actually happened unless one goes to check the job. Let's just always send a Slack notification if the job fails. Prompted by noticing that it failed recently because of coreos/fedora-coreos-streams#924 only by pure chance (I was looking at the job for another reason). Patch best viewed with whitespace ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 61a9d2b ("release-notes: updates for the 20240703 releases").
Desperately need #628.