Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI check for release notes YAML docs #934

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

aaradhak
Copy link
Member

This is a CI check for the release notes of next.yml, stable.yml and testing.yml to catch the syntax and schema errors in these files.

Ref: #628

travier
travier previously approved these changes Jul 31, 2024
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks great. Not tested. Have you tested it a bit wit invalid inputs?

.github/workflows/validate-release-notes.yml Outdated Show resolved Hide resolved
.github/workflows/validate-release-notes.yml Show resolved Hide resolved
@travier
Copy link
Member

travier commented Jul 31, 2024

Maybe we should make the Python script take all 3 files as input and check them all and report all errors directly to avoid a back and forth.

Maybe we should make it a commit hook as well. I vaguely remember that we have one here or something similar.

@aaradhak
Copy link
Member Author

Maybe we should make the Python script take all 3 files as input and check them all and report all errors directly to avoid a back and forth.

Maybe we should make it a commit hook as well. I vaguely remember that we have one here or something similar.

Yes, I am intending to input all 3 files as input and check all at once instead of back n forth. For the purpose of testing, I am using this approach now.

Also, I thought about the commit hook part as well. I am trying to figure out how to implement it here.

@aaradhak aaradhak changed the title CI check for release notes YAML doc CI check for release notes YAML docs Jul 31, 2024
@jmarrero jmarrero marked this pull request as ready for review August 2, 2024 20:10
@jmarrero jmarrero closed this Aug 2, 2024
@jmarrero jmarrero reopened this Aug 2, 2024
@aaradhak
Copy link
Member Author

aaradhak commented Aug 5, 2024

Thanks! That looks great. Not tested. Have you tested it a bit wit invalid inputs?

I tested this script with few invalid inputs and it seems to capture the errors as expected.

ci/check-release-notes.py Outdated Show resolved Hide resolved
ci/check-release-notes.py Outdated Show resolved Hide resolved
ci/check-release-notes.py Outdated Show resolved Hide resolved
.github/workflows/validate-release-notes.yml Outdated Show resolved Hide resolved
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks sane to me! Can you squash your commits?

This is a CI check for the release notes of next.yml, stable.yml and
testing.yml to catch the syntax and schema errors in these files.

Ref: coreos#628
@aaradhak
Copy link
Member Author

aaradhak commented Aug 8, 2024

I will be looking into adding the pre-commit hook post merge.

Copy link
Member

@gursewak1997 gursewak1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marmijo
Copy link
Member

marmijo commented Aug 8, 2024

Thanks for working on this!

@aaradhak aaradhak merged commit 9aee93a into coreos:main Aug 8, 2024
1 check passed
@aaradhak aaradhak deleted the cicheck branch August 8, 2024 18:45
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this pull request Aug 12, 2024
- This is a pre-commit hook using `pre-commit` framework to validate release notes YAML files.
- The hook checks for correct structure, formatting and required fields in the `release-notes` directory.
- This ensures consistency and correctness in release notes before committing changes.

Ref: coreos#934 (comment)
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this pull request Aug 12, 2024
- This is a pre-commit hook using `pre-commit` framework to validate release notes YAML files.
- The hook checks for correct structure, formatting and required fields in the `release-notes` directory.
- This ensures consistency in release notes before committing changes.

Ref: coreos#934 (comment)
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this pull request Aug 19, 2024
- This is a pre-commit hook using `pre-commit` framework to validate release notes YAML files.
- The hook checks for correct structure, formatting and required fields in the `release-notes` directory.
- This ensures consistency in release notes before committing changes.
- Added release notes validation to the `make syntax-check` target

Ref: coreos#934 (comment)
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this pull request Aug 20, 2024
- This is a pre-commit hook using `pre-commit` framework to validate release notes YAML files.
- The hook checks for correct structure, formatting and required fields in the `release-notes` directory.
- This ensures consistency in release notes before committing changes.
- Added release notes validation to the `make syntax-check` target

Ref: coreos#934 (comment)
aaradhak added a commit to aaradhak/fedora-coreos-streams that referenced this pull request Aug 20, 2024
- This is a pre-commit hook using `pre-commit` framework to validate release notes YAML files.
- The hook checks for correct structure, formatting and required fields in the `release-notes` directory.
- This ensures consistency in release notes before committing changes.
- Added release notes validation to the `make syntax-check` target

Ref: coreos#934 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants