Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawhide: 20220103: selinux denial causing systemd-network-generator service failure #1059

Closed
dustymabe opened this issue Jan 4, 2022 · 10 comments
Assignees
Labels
jira for syncing to jira kind/bug rawhide Issues that uniquely pertain to rawhide

Comments

@dustymabe
Copy link
Member

Our tests that test networking configuration via kernel arguments are failing because of SELinux denials causing the systemd-network-generator service to fail in our rawhide stream.

[2022-01-04T16:33:48.933Z] --- FAIL: ext.config.networking.prefer-ignition-networking (555.33s)
[2022-01-04T16:33:48.933Z]         harness.go:1249: Cluster failed starting machines: machine "5bffd725-9683-47c4-b64c-1fb8eb91c341" failed basic checks: some systemd units failed:
[2022-01-04T16:33:48.933Z] systemd-network-generator.service


[2022-01-04T16:35:34.817Z] --- FAIL: ext.config.networking.force-persist-ip (388.76s)
[2022-01-04T16:35:34.817Z]         harness.go:1249: Cluster failed starting machines: machine "b5b0354e-e771-495c-aaab-36cc98e47c6e" failed basic checks: some systemd units failed:
[2022-01-04T16:35:34.817Z] systemd-network-generator.service

I opened BZ#2037047 against selinux-policy to track a fix for getting the systemd-network-generator.service working again.

@dustymabe
Copy link
Member Author

dustymabe commented Jan 4, 2022

We have a few options here that I see for a short term workaround:

  • make the tests use enforcing=0 temporarily (would affect all streams and would need a reminder to revert)
  • snooze these tests for a while in rawhide
  • determine/decide that we absolutely don't need anything from systemd-network-generator and disable it.

@jlebon
Copy link
Member

jlebon commented Jan 4, 2022

determine/decide that we absolutely don't need anything from systemd-network-generator and disable it.

+1. I think for our own sanity we shouldn't have anything other than nm-initrd-generator generating things from network kargs.

@dustymabe
Copy link
Member Author

dustymabe commented Jan 4, 2022

determine/decide that we absolutely don't need anything from systemd-network-generator and disable it.

+1. I think for our own sanity we shouldn't have anything other than nm-initrd-generator generating things from network kargs.

I would mostly agree but there's some overlap where the systemd-network-generator does some things that are used even if we use NetworkManager (and not systemd-networkd). For example: systemd/systemd#21766 (comment)

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 4, 2022
They are failing right now because `systemd-network-generator` is
having issues writing files because of SELinux. See:

- coreos/fedora-coreos-tracker#1059
- https://bugzilla.redhat.com/show_bug.cgi?id=2037047
@dustymabe
Copy link
Member Author

proposal to go with snoozing for now: coreos/fedora-coreos-config#1400

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 4, 2022
They are failing right now because `systemd-network-generator` is
having issues writing files because of SELinux. See:

- coreos/fedora-coreos-tracker#1059
- https://bugzilla.redhat.com/show_bug.cgi?id=2037047
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jan 4, 2022
They are failing right now because `systemd-network-generator` is
having issues writing files because of SELinux. See:

- coreos/fedora-coreos-tracker#1059
- https://bugzilla.redhat.com/show_bug.cgi?id=2037047
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 12, 2022
Similar to 104ecf1 we need to snooze the new karg networking test
added in 0a577a1 on rawhide because of the same issue.

See coreos/fedora-coreos-tracker#1059
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jan 12, 2022
Similar to 104ecf1 we need to snooze the new karg networking test
added in 0a577a1 on rawhide because of the same issue.

See coreos/fedora-coreos-tracker#1059
@dustymabe
Copy link
Member Author

dustymabe commented Jan 15, 2022

bump-lockfile started failing because of this. We we are now hitting it on the systemd 249.7-2.fc35 -> 249.9-1.fc35 in Fedora 35. Let's pin systemd in testing/next for now and get more involved in the BZ to see if we can push a fix.

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jan 16, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jan 25, 2022
Currently no movement on the report BZ. I marked it as a prioritized
bug so we can hopefully get some fix soon.

coreos/fedora-coreos-tracker#1059
https://bugzilla.redhat.com/show_bug.cgi?id=2037047
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Jan 25, 2022
Currently no movement on the report BZ. I marked it as a prioritized
bug so we can hopefully get some fix soon.

coreos/fedora-coreos-tracker#1059
https://bugzilla.redhat.com/show_bug.cgi?id=2037047
@travier travier self-assigned this Feb 10, 2022
@travier travier added jira for syncing to jira rawhide Issues that uniquely pertain to rawhide labels Feb 10, 2022
cgwalters pushed a commit to cgwalters/fedora-coreos-config that referenced this issue Feb 10, 2022
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
cgwalters pushed a commit to cgwalters/fedora-coreos-config that referenced this issue Feb 10, 2022
Currently no movement on the report BZ. I marked it as a prioritized
bug so we can hopefully get some fix soon.

coreos/fedora-coreos-tracker#1059
https://bugzilla.redhat.com/show_bug.cgi?id=2037047
@dustymabe
Copy link
Member Author

The snooze for the following tests was extended in coreos/fedora-coreos-config#1543:

  • ext.config.networking.prefer-ignition-networking
  • ext.config.networking.force-persist-ip
  • ext.config.networking.mtu-on-bond-kargs

@dustymabe
Copy link
Member Author

The snooze for the following tests was extended in coreos/fedora-coreos-config#1576:

  • ext.config.networking.prefer-ignition-networking
  • ext.config.networking.force-persist-ip
  • ext.config.networking.mtu-on-bond-kargs

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Mar 15, 2022
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Mar 15, 2022
@dustymabe
Copy link
Member Author

I'm going to unfreeze systemd and workaround this for now: coreos/fedora-coreos-config#1604

I'll continue to monitor BZ#2037047 for any updates there.

@dustymabe
Copy link
Member Author

dustymabe commented Apr 6, 2022

A fix has been built for Fedora 36 for this. I'm not sure the fix is going to go to F35, but we don't necessarily need that. Let's fast-track the package in our next-devel stream (one PR against next-devel) and split out our masking to make it only apply to F35 (another PR to against the testing-devel branch). See coreos/fedora-coreos-config#1660 for an example of how to do this.

@dustymabe
Copy link
Member Author

Closing this out since it's fixed in F36 (next-devel) and Rawhide and will folow into our other streams.

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 10, 2022
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 11, 2022
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 11, 2022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
They are failing right now because `systemd-network-generator` is
having issues writing files because of SELinux. See:

- coreos/fedora-coreos-tracker#1059
- https://bugzilla.redhat.com/show_bug.cgi?id=2037047
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Similar to 104ecf1 we need to snooze the new karg networking test
added in 0a577a1 on rawhide because of the same issue.

See coreos/fedora-coreos-tracker#1059
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Currently no movement on the report BZ. I marked it as a prioritized
bug so we can hopefully get some fix soon.

coreos/fedora-coreos-tracker#1059
https://bugzilla.redhat.com/show_bug.cgi?id=2037047
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
They are failing right now because `systemd-network-generator` is
having issues writing files because of SELinux. See:

- coreos/fedora-coreos-tracker#1059
- https://bugzilla.redhat.com/show_bug.cgi?id=2037047
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Similar to 104ecf1 we need to snooze the new karg networking test
added in 0a577a1 on rawhide because of the same issue.

See coreos/fedora-coreos-tracker#1059
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
SELinux denials are causing systemd-network-generator to fail
running. coreos/fedora-coreos-tracker#1059
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Currently no movement on the report BZ. I marked it as a prioritized
bug so we can hopefully get some fix soon.

coreos/fedora-coreos-tracker#1059
https://bugzilla.redhat.com/show_bug.cgi?id=2037047
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira kind/bug rawhide Issues that uniquely pertain to rawhide
Projects
None yet
Development

No branches or pull requests

3 participants