Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rawhide: symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug broken #1496

Closed
gursewak1997 opened this issue May 18, 2023 · 9 comments
Labels

Comments

@gursewak1997
Copy link
Member

gursewak1997 commented May 18, 2023

Describe the bug

With the upgrade from kexec-tools 2.0.26-3.fc38 -> 2.0.26-4.fc39, we are seeing that the symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug cannot be validated.

[2023-05-16T13:06:29.748Z] May 16 13:06:28 qemu0 kola-runext-validate-symlinks[2078]: + [[ false == \f\a\l\s\e ]]

[2023-05-16T13:06:29.748Z] May 16 13:06:28 qemu0 kola-runext-validate-symlinks[2078]: + fatal 'Error: /usr/lib/debug/.build-id/36/96626d3b4b74691ca6d10f86971e546755f6ba.debug symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug which does not exist'

Expected behavior

The symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug should exist

Actual behavior

The symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug is broken

System details

[rawhide][x86_64] 39.20230516.91.0

Additional information

Bugzilla issue: https://bugzilla.redhat.com/show_bug.cgi?id=2208360

@gursewak1997 gursewak1997 changed the title symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug broken Rawhide: symlink to /usr/lib/debug/usr/lib64/bfd-plugins/libdep.so-2.40-7.fc39.x86_64.debug broken May 18, 2023
@travier
Copy link
Member

travier commented May 30, 2023

rpm -qf /usr/lib64/bfd-plugins/libdep.so
binutils-2.39-9.fc38.x86_64

@travier
Copy link
Member

travier commented May 30, 2023

As we don't ship any debug info in FCOS, I suggest that we:

  • Skip /usr/lib/debug entirely for the check
  • Add a post-process script in our manifests that entirely removes this folder and re-creates it empty

This should work around those failures that are not big enough for us to spend time on.

As Colin said in coreos/fedora-coreos-config#2427 (comment), this should fail in Fedora CI.

@dustymabe
Copy link
Member

More info: binutils is a new dependency of kdump that got brought in with the kexec-tools 2.0.26-3.fc38 -> 2.0.26-4.fc39 transition, which is why we are seeing this now.

@dustymabe
Copy link
Member

As we don't ship any debug info in FCOS, I suggest that we:

  • Skip /usr/lib/debug entirely for the check

I think that's fair.

  • Add a post-process script in our manifests that entirely removes this folder and re-creates it empty

I'm not sure I agree. I think we should do less modifying the original package delivered contents. What we could/should do is make sure no packages we include deliver files there (I assume it is some violation of packaging guidelines?).

@travier
Copy link
Member

travier commented May 30, 2023

  • Add a post-process script in our manifests that entirely removes this folder and re-creates it empty

I'm not sure I agree. I think we should do less modifying the original package delivered contents. What we could/should do is make sure no packages we include deliver files there (I assume it is some violation of packaging guidelines?).

Agree that this should be caught at a higher level, in Fedora infra / CI. Until that happens, I think it's a good example of a test where it should be a warning, but not a failure, as we can just workaround it until that happens properly in Fedora.

@dustymabe
Copy link
Member

For this particular issue the bug mentions that this should be fixed in binutils-2.40-9.fc39 (hopefully in the next rawhide compose).

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Jun 1, 2023
@travier
Copy link
Member

travier commented Jun 2, 2023

I think we should have kexec-tools only recommend binutils as it's only for UKI support and we don't support that for now.

Filed: https://src.fedoraproject.org/rpms/kexec-tools/pull-request/14

coiby pushed a commit to coiby/kexec-tools that referenced this issue Aug 21, 2023
UKI are not supported on rpm-ostree based Fedora variants so let's use
recommend for binutils for now to let those not include the package
until needed.

See: coreos/fedora-coreos-tracker#1496
See: ostreedev/ostree#2753
See: https://src.fedoraproject.org/rpms/kexec-tools/c/ea7be0608ed719cc1cb134ecf6ef51a4b7e9f104?branch=rawhide
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants