Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rawhide][x86_64]: root-reprovision.linear kola test fails #1648

Closed
gursewak1997 opened this issue Jan 15, 2024 · 7 comments · Fixed by coreos/fedora-coreos-config#2830
Closed

Comments

@gursewak1997
Copy link
Member

ext.config.root-reprovision.linear fails with the mdadm error. This has been caused with the latest kernel change from
kernel 6.8.0-0.rc0.20240111gitde927f6c0b07.4.fc40 -> 6.8.0-0.rc0.20240112git70d201a40823.5.fc40

[   19.216280] ignition[1029]: disks: createRaids: op(1): [finished] waiting for devices [/dev/disk/by-id/virtio-disk1 /dev/disk/by-id/virtio-disk2]
[   19.218194] ignition[1029]: disks: createRaids: created device alias for "/dev/disk/by-id/virtio-disk1": "/run/ignition/dev_aliases/dev/disk/by-id/virtio-disk1" -> "/dev/vda"
[   19.220269] ignition[1029]: disks: createRaids: created device alias for "/dev/disk/by-id/virtio-disk2": "/run/ignition/dev_aliases/dev/disk/by-id/virtio-disk2" -> "/dev/vdb"
[   19.221812] ignition[1029]: disks: createRaids: op(2): [started]  creating "foobar"
[   19.237356] md: personality for level -1 is not loaded!
[   19.237859] md: md127 stopped.
[   19.246186] ignition[1029]: disks: createRaids: op(2): [failed]   creating "foobar": exit status 1: 
Cmd: "mdadm" "--create" "foobar" "--force" "--run" "--homehost" "any" "--level" "linear" "--raid-devices" "2" "/run/ignition/dev_aliases/dev/disk/by-id/virtio-disk1" 
"/run/ignition/dev_aliases/dev/disk/by-id/virtio-disk2" Stdout: "mdadm: Defaulting to version 1.2 metadata\n" Stderr: "mdadm: RUN_ARRAY failed: Invalid argument\n"
[   19.253247] ignition[1029]: disks failed
[   19.253591] ignition[1029]: Full config:
[   19.253917] ignition[1029]: {
[�[0;1;31mFAILED�[0m] Failed to start �[0;1;39mignition-disks.service�[0m - Ignition (disks).
See 'systemctl status ignition-disks.service' for details.


@dustymabe
Copy link
Member

Since this is only a single test failure and the rc kernel changes a lot during the merge window (i.e. this problem could be fixed in the next kernel update) let's instead keep the latest kernel (so we keep testing kernel updates that will be coming in multiple times a week) but denylist the test either with a short snooze (one week) or no snooze at all and just warn: true.

@marmijo
Copy link
Member

marmijo commented Feb 1, 2024

It appears that md-linear has been deprecated for 2.5 years and was finally removed from the kernel.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.8-rc1&id=849d18e27be9a1253f2318cb4549cc857219d991

IIUIC, we could remove this test as linear raid is no longer supported.

@marmijo
Copy link
Member

marmijo commented Feb 2, 2024

However, md-linear is still available, although deprecated, in F39. We could denylist this test and only remove it when this change to the kernel is finally released in stable. What have we done in the past with changes like these?

@dustymabe
Copy link
Member

First off I want to say thank you @marmijo for digging into this. Great work finding the root cause!

However, md-linear is still available, although deprecated, in F39. We could denylist this test and only remove it when this change to the kernel is finally released in stable. What have we done in the past with changes like these?

It may still be in F39 but I'd think that's only because the 6.8 kernel hasn't landed in F39 yet, but it will, and I doubt the fedora kernel maintainer will patch it back in. He might if we ask really nicely, but I doubt it and I don't even know if we'd want him to.

I'd say we just drop it for Fedora CoreOS at least. Maybe we keep it for RHCOS, so we could move the source for the test to openshift/os repo ?

@jlebon WDYT?

@jlebon
Copy link
Member

jlebon commented Feb 2, 2024

Nice work @marmijo!

Yeah, agree on dropping it. Not even sure we need to keep it running for RHCOS, but not against either!

@dustymabe
Copy link
Member

+1 let's just drop it all around then.

@marmijo
Copy link
Member

marmijo commented Feb 2, 2024

+1, I'll open a PR to drop it

marmijo added a commit to marmijo/fedora-coreos-config that referenced this issue Feb 2, 2024
md-linear has been marked as deprecated for 2.5 years and was
finally removed from the kernel in v6.8.
Remove the `root-reprovision.linear` test from FCOS and, as a result,
RHCOS.
See coreos/fedora-coreos-tracker#1648 (comment)
for the decision to drop the test.
marmijo added a commit to marmijo/fedora-coreos-config that referenced this issue Feb 2, 2024
md-linear has been marked as deprecated for 2.5 years and was
finally removed from the kernel in v6.8.
Remove the `root-reprovision.linear` test from FCOS and, as a result,
RHCOS.
See coreos/fedora-coreos-tracker#1648 (comment)
for the decision to drop the test.
marmijo added a commit to coreos/fedora-coreos-config that referenced this issue Feb 3, 2024
md-linear has been marked as deprecated for 2.5 years and was
finally removed from the kernel in v6.8.
Remove the `root-reprovision.linear` test from FCOS and, as a result,
RHCOS.
See coreos/fedora-coreos-tracker#1648 (comment)
for the decision to drop the test.
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
md-linear has been marked as deprecated for 2.5 years and was
finally removed from the kernel in v6.8.
Remove the `root-reprovision.linear` test from FCOS and, as a result,
RHCOS.
See coreos/fedora-coreos-tracker#1648 (comment)
for the decision to drop the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants