Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rawhide: cliwrap causes looping in rpm-ostree.kernel-replace test. #1679

Open
dustymabe opened this issue Feb 27, 2024 · 1 comment
Open

rawhide: cliwrap causes looping in rpm-ostree.kernel-replace test. #1679

dustymabe opened this issue Feb 27, 2024 · 1 comment

Comments

@dustymabe
Copy link
Member

We enabled this in coreos/fedora-coreos-config#2858 but there seems to be a bug.

ext.config.rpm-ostree.kernel-replace calls dracut somewhere down in the stack and that is now looping:

Feb 27 17:48:55.590402 kola-runext.service[1483]: Use `rpm-ostree initramfs` to control client-side initramfs generation.
Feb 27 17:48:55.590402 kola-runext.service[1483]: rpm-ostree: Note: This system is image (rpm-ostree) based.
Feb 27 17:48:55.590402 kola-runext.service[1483]: rpm-ostree: Wrapped binary "dracut" was executed with not "known safe" arguments.
Feb 27 17:48:55.590402 kola-runext.service[1483]: rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`.
Feb 27 17:48:55.590402 kola-runext.service[1483]: rpm-ostree: Continuing execution in 5 seconds.
Feb 27 17:49:00.608327 kola-runext.service[1483]: This system is rpm-ostree based; initramfs handling is
Feb 27 17:49:00.608327 kola-runext.service[1483]: integrated with the underlying ostree transaction mechanism.
Feb 27 17:49:00.608327 kola-runext.service[1483]: Use `rpm-ostree initramfs` to control client-side initramfs generation.
Feb 27 17:49:00.608818 kola-runext.service[1483]: rpm-ostree: Note: This system is image (rpm-ostree) based.
Feb 27 17:49:00.608818 kola-runext.service[1483]: rpm-ostree: Wrapped binary "dracut" was executed with not "known safe" arguments.
Feb 27 17:49:00.608818 kola-runext.service[1483]: rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`.
Feb 27 17:49:00.608818 kola-runext.service[1483]: rpm-ostree: Continuing execution in 5 seconds.
Feb 27 17:49:05.626169 kola-runext.service[1483]: This system is rpm-ostree based; initramfs handling is
Feb 27 17:49:05.626169 kola-runext.service[1483]: integrated with the underlying ostree transaction mechanism.
Feb 27 17:49:05.626169 kola-runext.service[1483]: Use `rpm-ostree initramfs` to control client-side initramfs generation.
jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Feb 27, 2024
@jlebon
Revert "manifests: enable cliwrap on Fedora 40+"
6bc5d99 
This reverts commit 1cfbd77.

This seems to be breaking `ext.config.rpm-ostree.kernel-replace` at
least:

coreos/fedora-coreos-tracker#1679
@jlebon jlebon mentioned this issue Feb 27, 2024
Merged
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Feb 27, 2024
@jlebon @dustymabe
Revert "manifests: enable cliwrap on Fedora 40+"
3789b06 
This reverts commit 1cfbd77.

This seems to be breaking `ext.config.rpm-ostree.kernel-replace` at
least:

coreos/fedora-coreos-tracker#1679
jlebon added a commit to jlebon/rpm-ostree that referenced this issue Feb 29, 2024
@jlebon
cliwrap: make install-to-root idempotent
ddbcb90 
Right now, if a system is already cliwrapped, doing `install-to-root`
will incorrectly think the already wrapped entrypoints are the real
binaries and do the wrong thing.

Fix this by checking if the directory holding wrapped binaries already
exists. If yes, then no-op.

Fixes: coreos/fedora-coreos-tracker#1679
jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Feb 29, 2024
@jlebon
Reapply "manifests: enable cliwrap on Fedora 40+"
3ce2f77 
This reverts commit 3789b06.

The reported issue that motivated the revert[[1]] is due to an
rpm-ostree bug[[2]].

We can trivially work around this bug until the rpm-ostree fix lands in
FCOS, so let's do that and re-enable cliwrap.

[1]: coreos/fedora-coreos-tracker#1679
[2]: coreos/rpm-ostree#4848
@jlebon jlebon mentioned this issue Feb 29, 2024
Closed
@jlebon
Copy link
Member

jlebon commented Feb 29, 2024

Reopening to track inclusion in FCOS proper.

@jlebon jlebon reopened this Feb 29, 2024
jbtrystram pushed a commit to jbtrystram/fedora-coreos-config that referenced this issue Mar 1, 2024
@jlebon @jbtrystram
Revert "manifests: enable cliwrap on Fedora 40+"
52fac47 
This reverts commit 1cfbd77.

This seems to be breaking `ext.config.rpm-ostree.kernel-replace` at
least:

coreos/fedora-coreos-tracker#1679
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
@jlebon @aaradhak
Revert "manifests: enable cliwrap on Fedora 40+"
36bc752 
This reverts commit 1cfbd77.

This seems to be breaking `ext.config.rpm-ostree.kernel-replace` at
least:

coreos/fedora-coreos-tracker#1679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dustymabe @jlebon