Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x: sgdisk sometimes flakes during disk reprovision tests #1683

Closed
jschintag opened this issue Mar 4, 2024 · 3 comments · Fixed by coreos/fedora-coreos-config#2892
Closed
Assignees

Comments

@jschintag
Copy link

jschintag commented Mar 4, 2024

When running kola tests on fcos rawhide stream on s390x, sometimes tests are failing with the error:

[   24.182309] ignition[950]: disks: createPartitions: op(2): [started]  partitioning "/run/ignition/dev_aliases/dev/vda"

[   24.182339] ignition[950]: disks: createPartitions: op(2): op(3): [started]  reading partition table of "/run/ignition/dev_aliases/dev/vda"

[   24.182761] ignition[950]: disks: createPartitions: op(2): op(3): [finished] reading partition table of "/run/ignition/dev_aliases/dev/vda"

[   24.182807] ignition[950]: disks: createPartitions: op(2): running sgdisk with options: [--pretend --new=4:0:+1048576 --new=5:0:+0 /run/ignition/dev_aliases/dev/vda]

[   24.185900] ignition[950]: disks: createPartitions: op(2): [failed]   partitioning "/run/ignition/dev_aliases/dev/vda": Failed to pretend to create partitions. Err: exit status 2. Stderr:

Last seen in https://jenkins-fedora-coreos-pipeline.apps.ocp.fedoraproject.org/job/build-arch/3589, during ext.config.var-mount.simple

ext.config.var-mount.simple.zip

@jschintag jschintag self-assigned this Mar 7, 2024
@jlebon
Copy link
Member

jlebon commented Mar 8, 2024

Did you attach the right file? I don't see that snippet of logs in there. It seems like the job passed.

Also, in the job linked, it didn't fail on ext.config.root-reprovision.filesystem-only. (It failed earlier so never go to the --tag reprovision run.)

@jschintag
Copy link
Author

Did you attach the right file? I don't see that snippet of logs in there. It seems like the job passed.

Also, in the job linked, it didn't fail on ext.config.root-reprovision.filesystem-only. (It failed earlier so never go to the --tag reprovision run.)

Good catch, i think it also happened during that test in an earlier/later run and i got confused. I changed the text and uploaded the correct test output...

jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Mar 11, 2024
Hardcoding `/dev/vda` will break if there are more than one block device
may be attached (like on s390x where we attach another disk to pass in
Ignition). This is why the `/dev/disk/by-id/coreos-boot-disk` symlink
was added. Use it.

While we're here, switch from `platform: qemu` to
`tags: platform-independent` since they should theoretically work on any
platform now (though they are equivalent today).

Closes: coreos/fedora-coreos-tracker#1683
@jlebon
Copy link
Member

jlebon commented Mar 11, 2024

Can you test coreos/fedora-coreos-config#2892 ?

jlebon added a commit to coreos/fedora-coreos-config that referenced this issue Mar 13, 2024
Hardcoding `/dev/vda` will break if there are more than one block device
may be attached (like on s390x where we attach another disk to pass in
Ignition). This is why the `/dev/disk/by-id/coreos-boot-disk` symlink
was added. Use it.

While we're here, switch from `platform: qemu` to
`tags: platform-independent` since they should theoretically work on any
platform now (though they are equivalent today).

Closes: coreos/fedora-coreos-tracker#1683
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
Hardcoding `/dev/vda` will break if there are more than one block device
may be attached (like on s390x where we attach another disk to pass in
Ignition). This is why the `/dev/disk/by-id/coreos-boot-disk` symlink
was added. Use it.

While we're here, switch from `platform: qemu` to
`tags: platform-independent` since they should theoretically work on any
platform now (though they are equivalent today).

Closes: coreos/fedora-coreos-tracker#1683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants