-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all repos to peter-evans/create-pull-request@v6.0.2 #1699
Comments
Ideally, we should setup depandabot as well to get those updates in automatically. Example in https://github.com/travier/fedora-kinoite/blob/main/.github/dependabot.yml |
We can likely use https://github.com/coreos/repo-templates/tree/main/dependabot to do that. Edit: Hum, https://github.com/coreos/repo-templates/blob/main/dependabot/dependabot.yml needs tweaking. |
Mayyybe. If it's bumping across major versions, you can't just merge as is. You have to check what breaking changes happened and verify that it doesn't apply to you. And of course for the workflows we're talking about here, it's not really tested by CI. If it's bumping within major versions, then we don't need Dependabot for that; we just have to pin to a major version and not be more specific (e.g. |
So do we just bump to
|
How about for now bumping to |
@aaradhak All of those PRs are bumping the GHA to v6.0.2, but in #1699 (comment), my suggestion was to bump to v6 instead. Was that on purpose? |
@jlebon I was trying to look into the difference between v6.0.0 and v6.0.2. I have updated to v6.0.0 now. |
This is done now. Thanks @aaradhak! |
We're hitting a known issue that has been fixed in v6.0.1.
All instances where we use this action: https://github.com/search?q=org%3Acoreos+%22uses%3A+peter-evans%2Fcreate-pull-request%22&type=code
None of the breaking changes should affect us, so we should be good to just bump to v6.0.2.
The text was updated successfully, but these errors were encountered: