Remove i686 builds for packages maintained by the team #1716

travier · 2024-04-24T15:18:18Z

travier · 2024-04-24T15:44:22Z

I did the Butane one as it was more pressing with the failed build in F40. The other ones we can do progressively.

cgwalters · 2024-04-30T13:13:13Z

I am not sure that coreos should think of ostree/rpm-ostree as "our packages" here

jmarrero · 2024-04-30T13:38:46Z

I am not sure that coreos should think of ostree/rpm-ostree as "our packages" here

man, I feel this needs to be expanded on.

I assume you mean ostree/rpm-ostree should be co-maintained by every team/org involved in contributing to these.

But do you object to having this checklist here?

Is there a reason not to do this for ostree/rpm-ostree?

or you just want for us to be very specific with the wording and say something like packages we maintain and co-maintain?

travier · 2024-04-30T14:43:43Z

I've updated the title. I did not want to imply that we own those, but that generally maintain the packages in Fedora.

aaradhak · 2024-09-04T22:01:14Z

Its a work under progress:

Posting the links here for reference.

CLHM: https://src.fedoraproject.org/rpms/console-login-helper-messages/pull-request/14

aaradhak · 2024-09-06T17:21:34Z

rust -afterburn: https://src.fedoraproject.org/rpms/rust-afterburn/pull-request/38
rust-bootupd: https://src.fedoraproject.org/rpms/rust-bootupd/pull-request/9
rust-coreos-installer: https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/70
rust-ssh-key-dir: https://src.fedoraproject.org/rpms/rust-ssh-key-dir/pull-request/6
greenboot: https://src.fedoraproject.org/rpms/greenboot/pull-request/30

aaradhak · 2024-09-06T21:05:03Z

Based on Colin's comment, we might need to remove the i686 for greenboot

I have opened a PR to remove ix86 in greenboot

aaradhak · 2024-09-06T21:21:42Z

@travier The rpm-ostree spec seems to have ix86 excluded.

In this PR comment, it was recommend to drop ExclusiveArch: %{rust_arches} in addition to adding the ExcludeArch as it is no longer required for building on Fedora or RHEL. The ostree & rpm-ostree seem to have the ExclusiveArch: %{rust_arches} in the spec file. In that case, do we remove it in rpm-ostree?

HuijingHei · 2024-09-09T04:35:07Z

IMU, the current condition %if 0%{?rhel} >= 10 is only exclude i686 for rhel10, see build which still includes i686 builds for fedora.

We should expand it to include fedora like %if 0%{?rhel} >= 10 || 0%{?fedora} ?

Also should drop ExclusiveArch: %{rust_arches} as Rust packages are no longer required to have it (see doc and https://pagure.io/packaging-committee/pull-request/1222)

%rust_arches are no longer needed or required for building on Fedora or RHEL Ref:coreos/fedora-coreos-tracker#1716

aaradhak · 2024-09-13T15:56:14Z

PR for rpm-ostree

packaging/rpm-ostree.spec: Drop rust_arches rpm-ostree#5089

aaradhak · 2024-09-17T15:26:52Z

@travier The ostree spec seems to have ix86 excluded. I wanted to know if we would need to update anything else in ostree.

travier · 2024-09-17T15:31:11Z

It's only excluded for RHEL 10 for now: https://src.fedoraproject.org/rpms/ostree/blob/rawhide/f/ostree.spec#_20

This one is more complicated as you will have to find all the packages that depend on ostree and figure out if they can drop i686 support. You should be able to find those using: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval#Scope

aaradhak · 2024-09-17T15:38:59Z

ostree and rpm-ostree are not leaf packages.

aaradhak@fedora ~/coderepo/rpms/leafdrop (main)$ ./leafdrop ostree
NO: Package ostree is a required multilib package when installing Steam.
NO: Package ostree is a required multilib package when installing Wine.


aaradhak@fedora ~/coderepo/rpms/leafdrop (main)$ ./leafdrop rpm-ostree
rpm-ostree is Required by:
- anaconda-install-img-deps
- cockpit-ostree
- greenboot
- osbuild-ostree
rpm-ostree-devel is BuildRequired by:
- gnome-software
- plasma-discover
NO: Package rpm-ostree is not a leaf package on i686.

travier · 2024-09-18T15:11:13Z

For ostree, we likely won't be able to drop it from the Steam & Wine dependency list (or it will need a lot of effort) so we should probably end the work here.
For rpm-ostree:
- anaconda-install-img-deps: We'll need to start a discussion with the Anaconda team: https://github.com/rhinstaller/anaconda/discussions
- cockpit-ostree: Can be done directly like it's been done in cockpit already: https://src.fedoraproject.org/rpms/cockpit/blob/rawhide/f/cockpit.spec#_56
- osbuild-ostree: https://src.fedoraproject.org/rpms/osbuild is a noarch package so not sure why it's on this list
For rpm-ostree-devel:
- gnome-software: We should ask the https://pagure.io/fedora-workstation working group to consider dropping i686 builds of GNOME, or just GNOME Software at least
- plasma-discover: I've filed an issue to ask the KDE SIG: https://pagure.io/fedora-kde/SIG/issue/567

aaradhak · 2024-09-18T19:24:44Z

The cockpit-ostree spec is maintained upstream and is let by packit to auto-sync it.
~~[ ] cockpit-ostree: https://src.fedoraproject.org/rpms/cockpit-ostree/pull-request/52#~~

cockpit-ostree upstream PR
spec: Do not build on ix86 cockpit-project/cockpit-ostree#702

aaradhak · 2024-09-18T21:30:54Z

Discussion with the Anaconda team:

Removal of i686 Builds for Anaconda Package rhinstaller/anaconda#5882

Discussion with Fedora-workstation group regarding GNOME Software

https://pagure.io/fedora-workstation/issue/447

cockpit-ostree is one of the dependents of rpm-ostree. We are removing i686 buids on this pkg from fedora version 41 and above. Ref: coreos/fedora-coreos-tracker#1716 (comment)

Fedora does not support this anymore and we are currently blocking other packages to drop this dependency because we require them. See: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval coreos/fedora-coreos-tracker#1716 Suggested-by: Aashish Radhakrishnan

aaradhak · 2024-09-19T14:17:56Z

PR for anaconda pkg

Remove support for i686 builds rhinstaller/anaconda#5887

travier · 2024-10-14T10:15:36Z

plasma-discover: https://src.fedoraproject.org/rpms/plasma-discover/pull-request/26 (will be done with the next build/update).

travier · 2024-10-14T10:17:01Z

As we have the go from the Workstation team, we can make a PR for GNOME Software: https://pagure.io/fedora-workstation/issue/447

aaradhak · 2024-10-17T18:54:22Z

As we have the go from the Workstation team, we can make a PR for GNOME Software: https://pagure.io/fedora-workstation/issue/447

@travier Looks like gnome-software has already excluded the ix86 for RHEL 10 & above. It was updated 10 months ago.
https://src.fedoraproject.org/fork/aaradhak/rpms/gnome-software/c/3140f37d2d3b64c2889d143bcb9e6bee142981a4

travier · 2024-10-21T16:28:40Z

@travier Looks like gnome-software has already excluded the ix86 for RHEL 10 & above. It was updated 10 months ago. src.fedoraproject.org/fork/aaradhak/rpms/gnome-software/c/3140f37d2d3b64c2889d143bcb9e6bee142981a4

Then you can likely add Fedora >= 41 to this check as well.

aaradhak · 2024-10-23T14:43:03Z

@travier Looks like gnome-software has already excluded the ix86 for RHEL 10 & above. It was updated 10 months ago. src.fedoraproject.org/fork/aaradhak/rpms/gnome-software/c/3140f37d2d3b64c2889d143bcb9e6bee142981a4

Then you can likely add Fedora >= 41 to this check as well.

I have opened a PR for this check - https://src.fedoraproject.org/rpms/gnome-software/pull-request/10

debarshiray · 2024-10-23T16:25:57Z

@travier Looks like gnome-software has already excluded the ix86 for RHEL 10 & above. It was updated 10 months ago. src.fedoraproject.org/fork/aaradhak/rpms/gnome-software/c/3140f37d2d3b64c2889d143bcb9e6bee142981a4

Then you can likely add Fedora >= 41 to this check as well.

We are already in Final Freeze for Fedora 41. There's a Go/No-Go meeting tomorrow.

Does this fix an important enough bug that it will be granted a freeze break?

Otherwise, adding an ExcludeArch to a stable release doesn't seem to fit with Fedora's update policy for stable releases.

travier · 2024-10-23T16:34:37Z

There is no specific urgency. I hadn't realized that indeed. It's technically breaking but no-one is using those so 🤷🏻?

aaradhak · 2024-10-23T17:11:49Z

I have changed the fedora check to be from version 42.

aaradhak · 2024-10-24T14:26:09Z

Just realized that the Fedora ix86 is not built on Fedora already. I believe we would not need the fedora check.
Closed the PR without merging

travier · 2024-10-24T21:35:36Z

Ah indeed, my bad.

aaradhak · 2024-10-24T22:25:58Z

Do you think we can close this issue now ?

travier · 2024-10-25T13:11:32Z

I think we only have rpm-ostree in Fedora to do before we can consider this done.

aaradhak · 2024-10-25T14:39:16Z

From the previous discussion, as part of rpm-ostree, I see that osbuild-ostree is the only rpm that needs closure.
As its a noarch pkg , it was unsure why it was on this list.

travier added the kind/enhancement label Apr 24, 2024

travier assigned travier and unassigned travier Apr 24, 2024

travier added area/packaging meeting topics for meetings labels Apr 24, 2024

aaradhak self-assigned this Apr 24, 2024

travier removed the meeting topics for meetings label Apr 24, 2024

aaradhak added the jira for syncing to jira label Apr 30, 2024

travier changed the title ~~Remove i686 builds for all our packages~~ Remove i686 builds for packages maintained by the team Apr 30, 2024

aaradhak closed this as completed Sep 6, 2024

aaradhak reopened this Sep 6, 2024

aaradhak added a commit to aaradhak/rpm-ostree that referenced this issue Sep 13, 2024

packaging/rpm-ostree.spec: Drop rust_arches

16c4f8a

%rust_arches are no longer needed or required for building on Fedora or RHEL Ref:coreos/fedora-coreos-tracker#1716

aaradhak mentioned this issue Sep 13, 2024

packaging/rpm-ostree.spec: Drop rust_arches coreos/rpm-ostree#5089

Merged

martinpitt mentioned this issue Sep 19, 2024

spec: Do not build on ix86 cockpit-project/cockpit-ostree#702

Merged

jkonecny12 mentioned this issue Sep 19, 2024

Remove support for i686 builds rhinstaller/anaconda#5887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove i686 builds for packages maintained by the team #1716

Remove i686 builds for packages maintained by the team #1716

travier commented Apr 24, 2024 •

edited by aaradhak

Loading

travier commented Apr 24, 2024

cgwalters commented Apr 30, 2024

jmarrero commented Apr 30, 2024

travier commented Apr 30, 2024

aaradhak commented Sep 4, 2024 •

edited by travier

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

HuijingHei commented Sep 9, 2024 •

edited

Loading

aaradhak commented Sep 13, 2024 •

edited

Loading

aaradhak commented Sep 17, 2024

travier commented Sep 17, 2024

aaradhak commented Sep 17, 2024 •

edited

Loading

travier commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 19, 2024 •

edited

Loading

travier commented Oct 14, 2024 •

edited

Loading

travier commented Oct 14, 2024

aaradhak commented Oct 17, 2024 •

edited

Loading

travier commented Oct 21, 2024

aaradhak commented Oct 23, 2024

debarshiray commented Oct 23, 2024

travier commented Oct 23, 2024 •

edited

Loading

aaradhak commented Oct 23, 2024

aaradhak commented Oct 24, 2024

travier commented Oct 24, 2024

aaradhak commented Oct 24, 2024

travier commented Oct 25, 2024

aaradhak commented Oct 25, 2024

Remove i686 builds for packages maintained by the team #1716

Remove i686 builds for packages maintained by the team #1716

Comments

travier commented Apr 24, 2024 • edited by aaradhak Loading

Describe the enhancement

travier commented Apr 24, 2024

cgwalters commented Apr 30, 2024

jmarrero commented Apr 30, 2024

travier commented Apr 30, 2024

aaradhak commented Sep 4, 2024 • edited by travier Loading

aaradhak commented Sep 6, 2024 • edited Loading

aaradhak commented Sep 6, 2024 • edited Loading

aaradhak commented Sep 6, 2024 • edited Loading

HuijingHei commented Sep 9, 2024 • edited Loading

aaradhak commented Sep 13, 2024 • edited Loading

aaradhak commented Sep 17, 2024

travier commented Sep 17, 2024

aaradhak commented Sep 17, 2024 • edited Loading

travier commented Sep 18, 2024 • edited Loading

aaradhak commented Sep 18, 2024 • edited Loading

aaradhak commented Sep 18, 2024 • edited Loading

aaradhak commented Sep 19, 2024 • edited Loading

travier commented Oct 14, 2024 • edited Loading

travier commented Oct 14, 2024

aaradhak commented Oct 17, 2024 • edited Loading

travier commented Oct 21, 2024

aaradhak commented Oct 23, 2024

debarshiray commented Oct 23, 2024

travier commented Oct 23, 2024 • edited Loading

aaradhak commented Oct 23, 2024

aaradhak commented Oct 24, 2024

travier commented Oct 24, 2024

aaradhak commented Oct 24, 2024

travier commented Oct 25, 2024

aaradhak commented Oct 25, 2024

travier commented Apr 24, 2024 •

edited by aaradhak

Loading

aaradhak commented Sep 4, 2024 •

edited by travier

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

aaradhak commented Sep 6, 2024 •

edited

Loading

HuijingHei commented Sep 9, 2024 •

edited

Loading

aaradhak commented Sep 13, 2024 •

edited

Loading

aaradhak commented Sep 17, 2024 •

edited

Loading

travier commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 18, 2024 •

edited

Loading

aaradhak commented Sep 19, 2024 •

edited

Loading

travier commented Oct 14, 2024 •

edited

Loading

aaradhak commented Oct 17, 2024 •

edited

Loading

travier commented Oct 23, 2024 •

edited

Loading